GithubHelp home page GithubHelp logo

Comments (10)

dougwilson avatar dougwilson commented on July 19, 2024

PR welcome :)! Otherwise I'll look into getting this fixed in the next couple weeks without one.

from negotiator.

ethanresnick avatar ethanresnick commented on July 19, 2024

Cool! Would you accept a PEG parser written to the RFC? I already wrote that for my own project, since I wasn't confident that I could handle all the edge cases with a regexp, and I'd be happy to contribute it.

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

Everything has to run in Node.js 0.6, and last I looked at PEG.js that was not the case.

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

You can always build off the RegExp s in the content-type module if you like, if the PEG generator doesn't work in the old Node.js versions.

from negotiator.

ethanresnick avatar ethanresnick commented on July 19, 2024

Ahh compatibility woes :(

I'll try to whip up a PR then if I have the time, but I'm not sure I'll be able to get around to it very soon.

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

Feel free to check out my abandoned PEG.js file for this, though :) https://github.com/jshttp/http-utils/blob/peg/src/rfc7231.pegjs

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

Ok, sorry I've been absent on this issue at have been letting it sit. The biggest barrier to change was the test suite no longer functioned on Node.js 0.6. The last few days I worked on converting it to mocha so it'll run :) I've fixed the second issue so far.

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

Alrighty, both your issues should be fixed on master now. If you have time, I encourage you to test the changes (npm install jshttp/negotiator) to confirm/deny if your issue has been fixed :)!

from negotiator.

dougwilson avatar dougwilson commented on July 19, 2024

Published to npm as 0.5.2

from negotiator.

ethanresnick avatar ethanresnick commented on July 19, 2024

Thanks @dougwilson! I'll let you know if I encounter any problems!

from negotiator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.