Comments (10)
PR welcome :)! Otherwise I'll look into getting this fixed in the next couple weeks without one.
from negotiator.
Cool! Would you accept a PEG parser written to the RFC? I already wrote that for my own project, since I wasn't confident that I could handle all the edge cases with a regexp, and I'd be happy to contribute it.
from negotiator.
Everything has to run in Node.js 0.6, and last I looked at PEG.js that was not the case.
from negotiator.
You can always build off the RegExp s in the content-type module if you like, if the PEG generator doesn't work in the old Node.js versions.
from negotiator.
Ahh compatibility woes :(
I'll try to whip up a PR then if I have the time, but I'm not sure I'll be able to get around to it very soon.
from negotiator.
Feel free to check out my abandoned PEG.js file for this, though :) https://github.com/jshttp/http-utils/blob/peg/src/rfc7231.pegjs
from negotiator.
Ok, sorry I've been absent on this issue at have been letting it sit. The biggest barrier to change was the test suite no longer functioned on Node.js 0.6. The last few days I worked on converting it to mocha so it'll run :) I've fixed the second issue so far.
from negotiator.
Alrighty, both your issues should be fixed on master
now. If you have time, I encourage you to test the changes (npm install jshttp/negotiator
) to confirm/deny if your issue has been fixed :)!
from negotiator.
Published to npm as 0.5.2
from negotiator.
Thanks @dougwilson! I'll let you know if I encounter any problems!
from negotiator.
Related Issues (20)
- Dynamic requires don't support static loaders
- Parameter matching too strict HOT 8
- Parameter names should be case insensitive HOT 4
- Parameter value case-sensitivity is media-type specific HOT 5
- Is there a reason this library doesn't support charset as a parameter on Accept header? HOT 8
- `Accept: *` results in no media types. HOT 6
- language function does not return expected language HOT 1
- Negotiator behavior on duplicate accept content-types HOT 1
- es6 support HOT 2
- Caching the availableMediaTypes HOT 1
- Functionnal API HOT 2
- Accept-Language comparing standard currently differs between `getLanguagePriority` and `compareSpecs` HOT 5
- [Bug] parseCharset(str, i) changes value of i HOT 4
- [Question] More preferredCharset() stuff HOT 2
- [Question] parseMediaType(), and parameters after q-value HOT 4
- Ship version 1 and adopt semver? HOT 9
- 0.6.3 Release HOT 8
- Inconsistent mediaType/s handling HOT 1
- Returning */* no matter what I set as header. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from negotiator.