GithubHelp home page GithubHelp logo

Comments (6)

germanbisurgi avatar germanbisurgi commented on September 25, 2024

I think that it would be nice and useful to go one step further and improve the general accessibility of the json editor by adding accessibility features when missing and improve/correct existing ones.

Starting with meaningful aria-labels

how it is now:
meaningless-aria-labels

How can it be (more meaningful)
meaningful-aria-labels

@schmunk42 what do you think?

from json-editor.

schmunk42 avatar schmunk42 commented on September 25, 2024

@germanbisurgi is this addressed by #1465?

from json-editor.

germanbisurgi avatar germanbisurgi commented on September 25, 2024

Yes

from json-editor.

germanbisurgi avatar germanbisurgi commented on September 25, 2024

Implemented in #1465

from json-editor.

vishnu947 avatar vishnu947 commented on September 25, 2024

I am still seeing the Accessibility error for select dropdown:

I am using the latest json-editor/json-editor version :"@json-editor/json-editor": "^2.13.2"

This is the schema and data i am using :
Schema JSON :
{
"title": "Sales Forecasting",
"type": "object",
"properties": {
"cardMapping": {
"type": "array",
"format": "table",
"title": "Card Variables Mapping",
"items": {
"type": "object",
"properties": {
"value": {
"type": "string",
"title": "Variable Name",
"enum": [
"ScenarioId",
"Name",
"Description",
"Status",
"RUN_DATE",
"SCENARIO_STATUS",
"SALES_FORECAST",
"BRAND_ID",
"SEC_ATTR1",
"SEC_ATTR2"
]
},
"label": {
"type": "string",
"title": "Display Name"
}
}
}
}
},
"options": {
"disable_edit_json": "true"
}
}

Data JSON :
{
"cardMapping": [
{
"value": "Name",
"label": "Scenario Name"
},
{
"value": "ScenarioId",
"label": "Scenario Id"
},
{
"value": "Status",
"label": "Status"
},
{
"value": "RUN_DATE",
"label": "Run Date"
},
{
"value": "SCENARIO_STATUS",
"label": "Scenario Status"
},
{
"value": "SALES_FORECAST",
"label": "Forecast Number"
}
]
}

Attaching the screenshot from interactive demo for your reference :
Accessibilty Issue

from json-editor.

germanbisurgi avatar germanbisurgi commented on September 25, 2024

@vishnu947 Starting from version 2.14.0, you can use accessibility features. In the screenshot below, you'll see a select input without a label because of the table format, but it has an aria-label attribute to fix this.

select-aria-label scan

from json-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.