GithubHelp home page GithubHelp logo

Comments (22)

wdoekes avatar wdoekes commented on July 17, 2024

While your argument is perfectly valid with regards to the phone field, for the email field it is not.

We're building a resume here, so I'll only specify 1 e-mail: the one I want to be contacted on.

from resume-schema.

inadarei avatar inadarei commented on July 17, 2024

Ha, well the sample doc had multiple emails and multiple phones so that's what I was going with: http://jsonresume.org/

But I agree, my argument was about general approach. It can be applied to phone numbers, emails or social media links, depending on needs.

from resume-schema.

smizell avatar smizell commented on July 17, 2024

It looks like this pattern is already being used for things like skills, hobbies, references, etc. An array of anonymous objects (as proposed here) seems to fit in line with the rest of the document format.

from resume-schema.

fredsterss avatar fredsterss commented on July 17, 2024

Personally I have no idea why you'd want to share work anything with potential employers. I don't want work phone or email when I'm looking at resumes, and I would never share those with a potential employer. The rationale for having multiple makes no sense to me. Both should be constrained to a single entry imo.

Put another way, what is the use-case for having work and / or home for these fields?

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

More notes at duplicate #50

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

Put another way, what is the use-case for having work and / or home for these fields?

I can't actually come up with anything, I'm going to vote that we have a simple string for email and phone.

from resume-schema.

smizell avatar smizell commented on July 17, 2024

Even if email and phone become strings, I think that website and profiles could benefit from being anonymous objects as proposed by this issue.

{
  "profiles": [
    { "type": string, "url": string }
  ]
}

Where type can be Twitter, Github, etc. and url is the actual URL of the profile.

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

Makes sense to me, I will set up a page where you can view different versions of the specification and we can start moving towards merging these issues.

from resume-schema.

wdoekes avatar wdoekes commented on July 17, 2024

Put another way, what is the use-case for having work and / or home for these fields?

Back in the days, we had "home" phone and "mobile" phone.

However, since a decade now, (almost) everyone always has their mobile phone with them wherever they go, so that makes that point less valid. On the other hand, perhaps someone is reachable on a phone in a different country during a certain period.

And who says we'll still be using phone numbers in 10 years time?

Thinking out loud here. What about?

contact: [
    {description: "email", uri: "mailto:[email protected]"},
    {description: "phone during week 28", uri: "tel:+321987"},
    {description: "mobile phone", uri: "tel:+1234567"}
]

from resume-schema.

fredsterss avatar fredsterss commented on July 17, 2024

@wdoekes this still seems like unnecessary complexity - it's not like we're trying to define a way to always be able to get in touch with someone no matter what. This isn't a spec for an emergency contact. I think we need to balance brevity and ease of use with utility to the potential employer.

from resume-schema.

vote539 avatar vote539 commented on July 17, 2024

I like @wdoekes's contact array. It is much more future-proof than separate fields for email and phone. This sort-of reminds me of the days when they were drafting the HTML standard, where they put tags that are now obsolete at the top level, and it made things messy.

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

I'm going to still vote for phone and email as singular fields to give the theme designers an easier job.

When we do new major versions of the specification, we can release tools that auto update your resume.json to the latest spec version. Moving email and phone into a more abstract data type should be trivial if the use case arrises.

from resume-schema.

fredsterss avatar fredsterss commented on July 17, 2024

@thomasdavis +1

from resume-schema.

ocram avatar ocram commented on July 17, 2024

@thomasdavis +1 as well

from resume-schema.

DonDebonair avatar DonDebonair commented on July 17, 2024

@thomasdavis definitely +1 for simplicity. As a general note I think we should really think hard about the complexity of the schema and keep vigilant that we're not over-engineering things. The first version should not try to support every potential use-case.
Just have a look at resumes you have lying around and see if those contain multiple phonenumbers and/or email addresses for instance :)

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future.

from resume-schema.

shea256 avatar shea256 commented on July 17, 2024

What are the options here? Turn email into a list or keep it the way it is?

from resume-schema.

DonDebonair avatar DonDebonair commented on July 17, 2024

Options:

  • Turn email into a list
  • Keep it the way it is
  • Make it a simple string <- my preferred option.

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

Will just ask @opensourcegrrrl what she thinks, if it's a +1 for singular email and phone.

Then we will make the commit.

from resume-schema.

osg avatar osg commented on July 17, 2024

+1 for singular
On Jul 12, 2014 10:46 AM, "Thomas Davis" [email protected] wrote:

Will just ask @opensourcegrrrl https://github.com/opensourcegrrrl what
she thinks, if it's a +1 for singular email and phone.

Then we will make the commit.


Reply to this email directly or view it on GitHub
#27 (comment)
.

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

Ok marked as pull request needed.

email and phone to be changed to types string

from resume-schema.

thomasdavis avatar thomasdavis commented on July 17, 2024

This has been added to Change Log as complete, cheers!

from resume-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.