GithubHelp home page GithubHelp logo

Comments (6)

jstrieb avatar jstrieb commented on May 18, 2024 1

Sorry for the crazy delay on this! My semester just started back up, and I've been busy doing math homework.

@rahul-jha98 was kind enough to work on a fix for this issue. I verified that it works on all the devices I have access to and merged into master. I will leave this issue open for a couple of days just in case, but hopefully this is resolved!

from github-stats.

jstrieb avatar jstrieb commented on May 18, 2024

Thanks for bringing this to my attention! It's probably related to the fix I quickly pushed out for #12. I will try to take a look soon, but the key to solving it likely lies in analyzing the diff for the commit made to address that issue.

from github-stats.

rahul-jha98 avatar rahul-jha98 commented on May 18, 2024

@jstrieb Could I work on this issue??

from github-stats.

jstrieb avatar jstrieb commented on May 18, 2024

@rahul-jha98 thanks for taking an interest in this! I've been pretty busy lately and would appreciate the help getting to the bottom of this issue. I created a branch border-fix that you should make a PR on if you fix it or propose a solution. I may make some edits and will then test as much as I can on different browser/OS configurations before merging.

As I note above, this issue is probably caused by the fix for #12 (this commit).

Making everything work well in all browsers will likely be a challenge, so please note in any subsequent commits what configurations you have tested on. Once again, thanks for taking an interest in the project and being willing to contribute!

from github-stats.

rahul-jha98 avatar rahul-jha98 commented on May 18, 2024

@jstrieb Thanks for guiding me to the commit as it narrowed down where I had to look to solve the issue.
After fixing the languages.svg I noticed there was a difference in alignment in generated overview.svg and languages.svg. So I have taken the liberty to modify overview.svg as well so that both are now centred wrt to their respective frames. I have created the PR for the same.

For the sake of testing from my end I have verified that the new svg works in

  • Mac OS Catalina : Safari, Chrome, Firefox
  • Manjaro 20.2.1 (for checking on Linux): Chrome, Firefox
  • Windows 10: Chrome, Firefox

Also, I know it isn't easy for single person to maintain the project for the rest of us and would like to thank you for creating such an awesome repo for the community. I am happy to provide the small contributions I can to help maintain the project.

from github-stats.

jstrieb avatar jstrieb commented on May 18, 2024

Since there hasn't been any more discussion on this matter, I will assume the issue is fixed.

from github-stats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.