Comments (4)
Great, this is working now 👍 I'm in the middle of a big accessibility migration and this tool and https://github.com/angular/protractor-accessibility-plugin have both been life savers. Thanks for your hard work! I'll let you know if I find any other issues
from eslint-plugin-jsx-a11y.
Hey @jamsea - thanks for reporting this. Extracting the value of prop types is a hard problem. Static analysis tools (such as eslint) can't determine actual values of variables until runtime, so a linter cannot pick up whether a briefHeadline
is null or undefined. We can use react-a11y for that because this tool runs when running your app.
However, the first use case should not throw an error now in 0.4.3 - the code just didn't handle the case where a prop was a logical expression. So this should now be fixed if you reinstall.
I hope to in the near future extract all of my utils for parsing the JSX nodes to determine existence/truthy values into separate modules so that I can better implement and test all cases for what can be used as a prop (and so others can use to build awesome static analysis tools of props, as well!)
Let me know if you see this issue persist and please continue to file if you find more, it's super helpful! 💯
from eslint-plugin-jsx-a11y.
@jamsea ahh dude that is awesome, never seen that before. Just led me to this: https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules
Will use this as a reference to expand this project.
Glad to see you are focusing on accessibility :)
from eslint-plugin-jsx-a11y.
Great! Create issues for the rules you're working on. I might be able to help out. We have a team of about 18 front end engineers, so any issue we can catch at the linter level saves us time. That way we don't have to wait for protractor to run our entire test suite to catch violations after we check in code.
from eslint-plugin-jsx-a11y.
Related Issues (20)
- [feature] suggest tabindex 0 or -1 for interactive-supports-focus
- axe-core dependency breaks nodejs14 compliancy HOT 3
- jsx-a11y/control-has-associated-label: dangerouslySetInnerHTML should pass? HOT 3
- label-has-associated-control not checking an actual valid configuration HOT 1
- Extend alt-text rule to check for any element with role="img" as well HOT 3
- semver pkg - ReDoS Vulnerability HOT 1
- jsx-a11y/control-has-associated-label throws an error on table elements HOT 5
- Changelog links broken due to different repo HOT 1
- jsx-a11y/label-has-associated-control gives error when for is put HOT 3
- label-has-associated-control regression
- How to configure `eslint-plugin-jsx-a11y` in `eslint.config.js` HOT 5
- [label-has-associated-control] regression - rule errors when a label does not directly have text, even if it has htmlFor HOT 8
- jsx-a11y/control-has-associated-label triggers on TD element HOT 1
- Coordinate NodeJS version support with axe-core HOT 9
- [img-redundant-alt] `words` option does not work with double-byte character words.
- `alt-text`: missing warning for empty `alt` for `<input type="image" alt="" />`
- [label-has-associated-control] Glob format not supporting labelComponents HOT 1
- Snyk: MPL 2.0 license vulnerability in axe-core HOT 2
- anchor-has-content and aria-labelledby
- Lint error on valid way for associating a `label` to an `input` control HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-jsx-a11y.