Comments (5)
That’d be great, thanks!
from eslint-plugin-react.
That's because forwardRef's callback is not a component. Function components take context
as a second argument, not ref
.
from eslint-plugin-react.
Actually, the issue does not come from the ref
directly, it comes from having a second argument. If I use forwardRef
as described in React's docs, I still don't get an error from eslint.
From what I can see, this behavior is caused by this line in the rule's implementation: having more than one argument in the function will not execute the rule.
Second test:
const ErrorIsShown = ({ foo = {} }) => null;
const ErrorIsAbsent = forwardRef(function({ foo = {} }, ref) {
return null
});
from eslint-plugin-react.
I see what you mean. Given that it's fine to have , context
in a component, the rule should be triggered regardless of there being more than one param.
from eslint-plugin-react.
That is exactly it.
Do you want me to set up a PR fixing this?
from eslint-plugin-react.
Related Issues (20)
- [Bug]: autofix for `sort-prop-types` breaks code containing comments
- [Bug]: `jsx-curly-brace-presence` doesn't trigger on strings containing a quote character
- [Bug]: react/prop-types false positives since upgrading typescript-eslint to v8 HOT 4
- [Feature Request]: Add TypeScript types HOT 3
- [Bug]: Cannot ban only explicitSpread for jsx-props-no-spreading HOT 2
- [Bug]: Support ESLint v9.9.0 HOT 1
- [Bug]: `jsx-curly-brace-presence` still warns on strings containing unescaped entities HOT 9
- [Bug]: Warning: React version not specified in eslint-plugin-react settings HOT 4
- [Bug]: react/jsx-no-target-blank fix does not add "noopener" HOT 3
- Rule proposal: Auto fix `prop={prop}` to `{...{prop}}` HOT 4
- [Bug]: Prop-types rules ignored for lowercase functional components HOT 7
- [Feature Request]: Add `allowedElements` option to `jsx-no-literals` HOT 4
- [Bug]: `hook-use-state` suggested fix should update all reference HOT 2
- [Bug]: `no-leaked-render` won't accept explicit `Boolean()` coercion, only implicit coercion with `!!` HOT 1
- [Bug]: `jsx-curly-brace-presence` creating invalid code when auto-fixing HOT 4
- [Bug]: indentation incorrect HOT 2
- [Feature Request]: Improve documention for new eslint 9 flat configuration for shared monorepo project HOT 3
- [Bug]: "Do not use isMounted" linting errors after upgrading to latest `eslint-plugin-react` (v7.36.0) HOT 9
- [Bug]: If boolean props are in JSX, the react/jsx-no-literals rule in latest update(7.36.0) throws exception and breaks ESLINT HOT 1
- [Bug]: `react/jsx-no-literals` crashes with `Cannot read properties of null (reading 'type')` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-react.