GithubHelp home page GithubHelp logo

Comments (2)

petehunt avatar petehunt commented on May 22, 2024

I am not planning on working on an optimizer in the near future. I have not found there to be any performance problems with the purely inline styles based approach in practice. In theory there may be, and this repo serves to prove that it is possible to fix these theoretical performance issues.

Closing this out but I would be happy to accept a PR that adds even a most basic optimizer.

from jsxstyle.

paulwehner avatar paulwehner commented on May 22, 2024

Thanks for letting me know!

So if I were to start developing an app with this library would you suggest that for development I use:

{test: /.js$/, loader: 'jsx-loader?harmony!' + path.join(__dirname, 'node_modules', 'jsxstyle', 'lib', 'webpackLoader.js') + '?LayoutConstants=' + path.join(__dirname, 'LayoutConstants.js')}

Because as you mentioned "It also makes the web inspector harder to use since you can't update all instances of a component on the page simultaneously."

But when putting it into production switch back to:

{test: /.js$/, loader: 'jsx-loader?harmony'},

And just use inline styles? To back-up your in practice point, the guys who are developing Radium mentioned that when you gzip your files, the size difference isn't significant even if you have a component that repeats many times on the page.


FYI - There is a reddit thread happening at the moment that discusses your library: http://www.reddit.com/r/reactjs/comments/344e0o/what_do_you_you_guys_think_of_petehuntjsxstyle_is/

from jsxstyle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.