db:migrate failing on install w/ v2.5.1 about cookbook-redmine

[fbrier]

I read through all the Redmine release notes between 2.2.4 and 2.5.1 and saw no changes to the tools or ruby libraries or packages or database features that would explain why 2.5.1 would behave differently on a clean install. Also, why would db:migrate execute on a clean install?

[fbrier]

So I noticed the mysql gem was not installed. So I installed it. Didn't work. But I did see Juanje's comment about the Chef gems possibly being in a different path. After reading about Chef logging, I re-ran chef-client and got the message, "Could not find gem 'mysql (~> 2.8.1) ruby' in the gems available on this machine." But then I read that Redmine does not include the mysql gem in its bundle definition and you have to specify it when installing. So why would it work for 2.2.4 and not 2.5.1? That has not changed. Still researching...

[fbrier]

Something must have changed to require the mysql gem to be added. In recipes/source.rb, the mysql gem has to be explicitly added:

     gem_package "bundler" do
       action :install
     end
+    gem_package "mysql" do
+      package_name "mysql"
+      version "2.8.1"
+      action :install
+    end

This seems to have solved the problem as 2.5.1 stable is now installed and operational. I did make one other change that I believe is unrelated, but appears to be a bug. In the same file, it appears that the execute bundle install command's parameters are reversed. Please feel free to let me know if I am off-base on these changes. Thank you.

     case adapter
     when "mysql"
-      execute "bundle install --without development test postgresql sqlite" do
+      execute "bundle install --without development test mysql sqlite" do
         cwd release_path
       end
     when "postgresql"
-      execute "bundle install --without development test mysql sqlite" do
+      execute "bundle install --without development test postgresql sqlite" do
         cwd release_path
       end
     end

[jniggemann]

Never looked at chef before and chances are I might be wrong about this, but

when "mysql"
   execute "bundle install --without development test mysql sqlite" do
   cwd release_path

doesn't look OK: You're in a case statement branch with adapter==mysql, hence it makes no sense to tell bundler to not use the mysql database...

[fbrier]

Thank you for logging into the project. Your hint on the redmine website zeroed me in. I'd actually caught the error you saw and posted it in the previous comment, although I don't think that is what was causing the db:migrate to fail. Thank you again. My next thought is to figure out how to do redmine plugins in the cookbook and integrate julionc's gitolite cookbook with the gitolite/redmine integration.