produce_or_load doubles filename prefixes about drwatson.jl

[Datseris]

oh shit this looks like a super duper major bug that we have to fix asap. it may break people's code when we fix it but we have to!!! And we have to put a test for it as well!!!!!!!!!!!

[Datseris]

@pjgorski your solution is correct! Could you please open a PR?

[Datseris]

I think this bug was introduced when we allowed produce_or_load to work with arbitrary naming functions, such as the hash maps. So thankfully it is a recent bug.

[jonas-schulze]

This is still (or again, perhaps) broken on v2.13.0. The following MWE will produce both Experiment.jld2 and Experiment_Experiment.jld2. Removing this line may fix this issue. Would doing so introduce any new bugs?

using DrWatson

struct Experiment end

DrWatson.default_prefix(::Experiment) = "Experiment"

filename(c) = savename(c; connector=" ")
produce(::Experiment) = Dict("data" => randn())
produce_or_load(produce, Experiment()) # good
produce_or_load(produce, Experiment(); filename) # bad

[Datseris]

@jonas-schulze if you put in a PR together and add a test for it we can see if anything breaks!