broken GeoInterface.convert(GeometryBasics.MultiPolygon) about geometrybasics.jl

[sjkelly]

The error message suggests we define:

  GeometryBasics.Point{S, T}(::Base.Generator) where {S, T}

Because:

 (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/kris/.julia/packages/StaticArrays/PUoe1/src/SArray.jl:54
  GeometryBasics.Point{S, T}(x) where {S, T} in GeometryBasics at /home/kris/.julia/packages/GeometryBasics/6JxlJ/src/fixed_arrays.jl:44

Are ambiguous.

[rafaqz]

I think there is a simpler fix than either of these, we just need to be more a little more explicit than using coordinates.

@KingBoomie if you have time to make a PR, we can check dimensionality of the geometry using GeoInterface.is3d

Something like this is a little simpler, more often type stable, and should work similarly to your code:

function GeoInterface.convert(::Type{LineString}, type::LineStringTrait, geom)
    points = if GeoInterface.is3d(geom) 
       [Point{3, Float64}(GeoInterface.x(p), GeoInterface.y(p), GeoInterface.z(p)) for p in getgeom(geom)]
    else
       [Point{2, Float64}(GeoInterface.x(p), GeoInterface.y(p)) for p in getgeom(geom)]
    end
    return LineString(points)
end

Probably defining the Array with undef as you are is actually faster than this though, so feel free to use that instead.