GithubHelp home page GithubHelp logo

Comments (4)

twadleigh avatar twadleigh commented on June 24, 2024

Hmm. I'd be happy to entertain a pull request, but I'm not sure this really belongs in the library. You can accomplish this with an explicit loop or comprehension (or map, as you note), in which case it seems superfluous to add to the library (which is mostly about code generation), or you can convert it to generic matrix multiplication, in which case it wouldn't really belong in this library, either.

from oldimmutablearrays.jl.

babaq avatar babaq commented on June 24, 2024

Your argument makes a lot of sense. the proposed functionality actually means to transform or multiply each of Vector4 in an array with a Matrix4x4. Adding to * function may pollute the meaning of matrix multiplication, but it does fit into .* which is simpler than the equivalent for loop or map. I was just thinking from a user perspective hoping those things automagically work:)

one can always convert Vector{Vector4} to generic matrix, that make me thinking is it right to support operation between ImmutableArrays and Arrays

tm=Matrix4x4(1.0)
a=Vector4(2.0)
tm*a # result in Vector4
[tm]*[a] # result in 4-element Vector
tm*[a] # doesn't work
[tm]*a # doesn't work

i am skeptical of any complication of support this, maybe any operation between ImmutableArrays and generic Arrays should return generic Arrays.

from oldimmutablearrays.jl.

twadleigh avatar twadleigh commented on June 24, 2024

The "it should just work" argument does make sense. And, yes, I'd agree that any mixing of ImmutableArray and other arrays should make vanilla arrays.

Could you spec out some definitions for the additional functionality you'd like to see in a PR or gist?

Also, just a heads-up, but it's been a looong time since I've had my head in this code, so it might take me a while to spin up on thinking about the best way to integrate it.

Thanks for making the effort to contribute.

from oldimmutablearrays.jl.

babaq avatar babaq commented on June 24, 2024

Sure, i'll try to make it happen:)

from oldimmutablearrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.