Comments (8)
Maybe ColorScheme
could itself be in <: AbstractVector
and that would be solved. It already defines the whole abstract array interface, it may as well be an getindex
AbstractVector
from colorschemes.jl.
Sounds good to me - it's a long time since I made this package (Julia v0.4) ... :) Make sure you don't break the entire plotting ecosystem... :)
from colorschemes.jl.
Eeeek that was my worry... We would have to test all the dependent packages before merging.
from colorschemes.jl.
Maybe this change merits a major, breaking release? That way you wouldn't (technically) break any package that depends on ColorSchemes. I can't speak for everybody but I'd welcome the improved load times.
from colorschemes.jl.
Why would this be a breaking change? Are people doing math with the color vector? It's just a list of colors.
from colorschemes.jl.
This mostly works and package load time is less than half of what it is with StaticArrays, but documentation breaks
https://travis-ci.com/github/rafaqz/ColorSchemes.jl/jobs/402345022
I think using Tuples loses a bunch of show
methods for vectors of colors. So they will also no longer show in atom etc. I'm not sure how much work that is to fix.
from colorschemes.jl.
I don't think there are any tests for show
at the moment... :( I could fix the documentation to not automatically insert a colorscheme by default, but it would be better if there was some kind of show
method perhaps.
from colorschemes.jl.
I really like seeing the colorscheme in atom - I guess it would mean adding a method here in Colors.jl?
https://github.com/JuliaGraphics/Colors.jl/blob/0890b410940fa9645496a394e5c449ef7104769a/src/display.jl#L26
The AbstractArray
interface does seem kinda handy ;) I'm wondering if it's worth losing the simplicity of that for 1 second of start time...
from colorschemes.jl.
Related Issues (20)
- OutOfMemoryError() HOT 1
- Release 3.20.0 HOT 1
- Release 3.21.0 HOT 1
- Release v3.22.0 HOT 1
- Kindlmann colormap HOT 4
- Release 3.23.0 HOT 1
- Scientific colour maps v8.0 HOT 6
- PNW colors HOT 6
- Release 3.24.0 HOT 1
- That `*` can be used to concatenate should be documented
- How to control the center color of diverging colorschemes HOT 2
- How do I know if a color scheme is continuous or categorical? HOT 2
- A consistent case pattern
- Unnecesary licence files
- Release v3.25.0 HOT 1
- Documentation `get_inverse` example is broken HOT 1
- optimized get(colorscheme, data) function HOT 1
- Release 3.18.0 HOT 3
- Release 3.19.0 HOT 1
- `firstindex` method error in color scheme HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from colorschemes.jl.