GithubHelp home page GithubHelp logo

Comments (8)

rafaqz avatar rafaqz commented on July 4, 2024 2

Maybe ColorScheme could itself be in <: AbstractVector and that would be solved. It already defines getindex the whole abstract array interface, it may as well be an AbstractVector

from colorschemes.jl.

cormullion avatar cormullion commented on July 4, 2024

Sounds good to me - it's a long time since I made this package (Julia v0.4) ... :) Make sure you don't break the entire plotting ecosystem... :)

from colorschemes.jl.

rafaqz avatar rafaqz commented on July 4, 2024

Eeeek that was my worry... We would have to test all the dependent packages before merging.

from colorschemes.jl.

mbaz avatar mbaz commented on July 4, 2024

Maybe this change merits a major, breaking release? That way you wouldn't (technically) break any package that depends on ColorSchemes. I can't speak for everybody but I'd welcome the improved load times.

from colorschemes.jl.

KristofferC avatar KristofferC commented on July 4, 2024

Why would this be a breaking change? Are people doing math with the color vector? It's just a list of colors.

from colorschemes.jl.

rafaqz avatar rafaqz commented on July 4, 2024

This mostly works and package load time is less than half of what it is with StaticArrays, but documentation breaks
https://travis-ci.com/github/rafaqz/ColorSchemes.jl/jobs/402345022

I think using Tuples loses a bunch of show methods for vectors of colors. So they will also no longer show in atom etc. I'm not sure how much work that is to fix.

from colorschemes.jl.

cormullion avatar cormullion commented on July 4, 2024

I don't think there are any tests for show at the moment... :( I could fix the documentation to not automatically insert a colorscheme by default, but it would be better if there was some kind of show method perhaps.

from colorschemes.jl.

rafaqz avatar rafaqz commented on July 4, 2024

I really like seeing the colorscheme in atom - I guess it would mean adding a method here in Colors.jl?
https://github.com/JuliaGraphics/Colors.jl/blob/0890b410940fa9645496a394e5c449ef7104769a/src/display.jl#L26

The AbstractArray interface does seem kinda handy ;) I'm wondering if it's worth losing the simplicity of that for 1 second of start time...

from colorschemes.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.