store the color result using IndirectArrays about ditherpunk.jl

[adrhill]

Would you just use an IndirectArray before or after applying the dithering algorithm?

[johnnychen94]

I think it's making the output of the dithering algorithm an IndirectArray, and let the consumers of dither decide whether they need a collect. For fixed color dither this should save a bunch of memory I believe.

[adrhill]

Sounds good! If a regular array is passed to dither!, should it be turned into an IndirectArray too?

This is also a good excuse to add #35. ;)

[johnnychen94]

If a regular array is passed to dither!, should it be turned into an IndirectArray too?

Oh for this you simply can't, because if you create a new array out for dither!(out, img), then it's a different memory.

function f!(out, src)
    out = zeros(4, 4)
    out .= src
    return out # this `out` is not the outside `out`
end

out = zeros(4, 4);
src = rand(4, 4);
f!(out, src)
out == src # false

But it's doable to out .= inner_indirect_array_out before returning.