Comments (10)
Hi, this is something that has been previously discussed and it seems like the 3000 character limit still holds.
Here is the previous answer: comment
from semantic-release-slack-bot.
Have you successfully tried the package with messages longer than 3000 character? I think it might be possible to have longer messages in case the section block is not used.
from semantic-release-slack-bot.
Yes I have experimented with very long messages and more character can get through, but not anywhere near 40000. I have a feeling the limit is based on displayed characters not actual characters, e.g. for a link that displays text is shorter than the full label and URL markup. Just a theory but increasing the max limit definitely allowed more characters through in my testing.
from semantic-release-slack-bot.
AFAIK the limit for a message is 40000 characters. However, there is a much stricter limit to consider. When using a section
, the character limit in the section is only 3000. Have you tried using a section with more than 3000 characters or only a message?
We are considering to allow a much larger character length when the user inputs a template, but if they use a section
the limit should be the same.
from semantic-release-slack-bot.
Hnmm I am on holiday this week, so I cannot check. But, I was using an attachment text field with more than 3000 characters, and saw more characters on slack with a higher max limit.
from semantic-release-slack-bot.
Ok so sending this in a message body to slack:
{
"attachments": [
{
"title": "Length test",
"text": "Lorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\nLorem ipsum dolor sit amet consectetur, adipisicing elit. Nihil natus voluptates quisquam assumenda doloremque, ducimus iste ullam, ut dolorum eius delectus quibusdam maxime voluptatum a. Tenetur quasi iste vero ipsum!\n\n"
}
]
}
outputs all of the paragraphs in the message which is around 5500 characters:
from semantic-release-slack-bot.
The original limit is explicitly based on section
, which of course is not mandatory in the case of using templates. Do you think it is possible to detect if there is a section
in the template and limit that section
to ~3000 characters, but otherwise raise the threshold to a much higher limit (~40,000)?
I do also agree that there should be a way to change the limits, but it should be very clear that it is an unsafe action, and having good defaults should be a priority.
Do you think it would be more clear that we do not recommend to change the config if it is called something like UNSAFE_MAX_LENGTH
instead of MAX_LENGTH
?
from semantic-release-slack-bot.
UNSAFE_MAX_LENGTH
sounds sensible to me. It seems that the new blocks api has some more stringent guidelines, e.g: the fields array in a section can have a maximum text length of 2000 and only contain 10 items. Should that be sanitised as well?
I was trying to find some-sort of schema, but slack does not seem to provide anything outside of some TypeScript types (which don't include property length). Also their own node webhook API does not do any sanitisation.
I guess there are a few options:
- Always cap section text at 3000 characters, and default the
UNSAFE_MAX_LIMIT
to 3000 also but allow that to be configured for other fields at the users risk. - Have separate options for different types of fields, so the user can increase the section text limit as well as the attachments text etc.
- Add exact sanitisation based on the limits specified in the docs, perhaps based on an JSON Schema file that would be easily updatable. Perhaps said schema can be overrode as an option, so the user can update limits as they see fit?
from semantic-release-slack-bot.
This problem is more complicated than I first thought 😅 Thanks for the extensive explanation!
I think option 3 is the nicest, but it might not be feasible. I would suggest doing option 1 one until a better solution comes. It will give the control and responsibility to the users of the plugin.
from semantic-release-slack-bot.
🎉 This issue has been resolved in version 1.4.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from semantic-release-slack-bot.
Related Issues (20)
- SLACK CONNECTION FAILED Only absolute URLs are supported HOT 4
- Fails with latest semantic-release versions HOT 3
- TypeError: Cannot read properties of undefined (reading 'name') HOT 7
- Adding slack app fails after entering channel name HOT 6
- slack bot should extend the accepted semantic release version to 21.0 HOT 10
- Slack channel from configs doesn't work when using token
- Vulnerability issue in node-fetch
- Invalid release url for selfhosted GitLab HOT 1
- Slack Webhook doesn't respect proxy environment variables
- Unable to add the app
- Error after installation with micromark package
- Examples Request HOT 5
- Question: support for Github releases? HOT 1
- Bump dependencies versions HOT 3
- Configuration for Slack channel HOT 10
- Support for [email protected] HOT 2
- [email protected] requires Node 14 which seems to be a breaking change HOT 4
- In the slack generated GitLab tag link is wrong! HOT 13
- Slack Message Showing version as a channel (private channel) HOT 9
- Is SLACK_ICON and SLACK_NAME working? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-release-slack-bot.