Why is the kernel client class pinned to AsyncKernelClient? about nbclient

[davidbrochart]

Hi Kevin,
If you want to use your own kernel manager, you can pass it to the NotebookClient. Have you tried that?
Otherwise, nbclient having inherently an async execution model, it will indeed set up an async kernel client.

[kevin-bates]

Hi David - thanks for the quick response.

Because I'm really going through Papermill here, I am specifying kernel_manager_class and need my NotebookClient subclass to instantiate the specified kernel manager instance and its specific (async) kernel client. I do not want to have to instantiate an instance first.

So is the reason for this forced override purely to ensure an async kernel client is used even in the classic case where a synchronous kernel manager is used? That seems to be the case since the default value for the kernel_manager_class trait is already AsyncKernelManager and it already specifies AsyncKernelClient as its client.

If nbclient requires an async kernel client (and a subclass of AsyncKernelClient for that matter), it seems it should only set the client_class trait on the KernelManager if it currently specifies juptyer_client.client.KernelClient and not unconditionally. Would that be sufficient?

if self.km.client_class == 'jupyter_client.client.KernelClient':
    self.km.client_class = 'jupyter_client.asynchronous.AsyncKernelClient'

This way, other kernel managers can bring their own async kernel client implementations.
(I get the expected results in my implementation after making this change.)

[davidbrochart]

Would that be sufficient?

if self.km.client_class == 'jupyter_client.client.KernelClient':
    self.km.client_class = 'jupyter_client.asynchronous.AsyncKernelClient'

Yes, this looks good to me. Thanks for looking into it Kevin!
If you feel like opening a PR, I'll be glad to merge it. Otherwise I can make the change.

[MSeal]

It might be nice for KernelManagers to be able to optionally supply a suggested KernelClient class so we could let a kernel manager assignment alone apply sane default client associations when the user isn't sure.

[davidbrochart]

Isn't it why we have client_class in the kernel managers?

[MSeal]

Yes. That's what I get for a quick response from my phone without thinking. Apologies and ignore that comment.

[davidbrochart]

No worries Matthew! My question was really for me to check if I understood correctly 😃

[kevin-bates]

Addressed by #117