Comments (8)
Hi @esvhd, thanks for opening an issue. I can reproduce the bug, but unfortunately fixing it in nbclient won't be enough since prompt-toolkit also has the issue, and they require python>=3.6.1 for that reason. Out of curiosity, what version of prompt-toolkit do you have?
from nbclient.
Hi @davidbrochart , thanks for taking the time to look at this. I'm using prompt-toolkit 2.0.4
in this environment.
from nbclient.
I see, I think they didn't have type checking yet in this version, so I guess that a fix in nbclient would work for you. Unfortunately I couldn't find a nice way to ignore the AsyncGenerator
return type of async_setup_kernel
depending on the python version.
#119 just removes the type. On the other hand, I'm not sure having this return type is of great value. So if nobody has an objection, I will go ahead and merge it.
from nbclient.
from nbclient.
cc @MSeal @SylvainCorlay
We can either merge #119 which removes type checking for the return value of async_setup_kernel
, or require python>=3.6.1
instead of currently python>=3.6
.
Thoughts?
from nbclient.
I'd prefer we require python >= 3.6.1
from nbclient.
I'd prefer we require
python >= 3.6.1
Same. 3.6.0 will also have outstanding security issues...
from nbclient.
Sorry @esvhd, we won't support python 3.6.0 anymore.
from nbclient.
Related Issues (20)
- Using nbclient to talk to jupyter lab running remotely HOT 10
- Renamed default branch to main
- 0.6.1: sphinx faiils because missing file HOT 2
- Background Python process after running tests
- How to reuse exsisting kernel? HOT 4
- Test failure in ipywidgets 8 HOT 2
- nbclient 0.6.6 doesn't report cell magic error properly
- Cell caching HOT 6
- just_run does not close event loop it creates HOT 2
- Project dependencies may have API risk issues HOT 2
- 0.7.1: pytest is failing because missing ` jupyter_core.utils.ensure_async` HOT 11
- jupyter_core version constraint is invalid HOT 3
- nbclient >= 0.7.1 raises ImportError when trying to open a notebook HOT 1
- AttributeError: 'KernelManager' object has no attribute 'cleanup' HOT 5
- `NotebookClient.wait_for_reply` hangs with jupyter_client 8 or later HOT 4
- Is it possible to programmatically inspect variables of a NotebookNode? HOT 5
- output of type `stream` is split over multiple cells HOT 10
- execute_cell running error HOT 4
- ipykernel.comm.Comm is deprecated HOT 3
- Calling `jupyter-execute` runs the notebook but doesn't save it HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbclient.