GithubHelp home page GithubHelp logo

Comments (3)

maresb avatar maresb commented on May 29, 2024

Adding a package to conda-forge is often as simple as running Grayskull to generate a PR in staged-recipes.

Anyone is welcome to clone my branch and fix things up to get this published on conda-forge.

A few initial observations:

  • The linter is complaining about deleting example/meta.yaml but I obviously didn't delete it, so perhaps staged-recipes is temporarily in an inconsistent state.
  • This package is vendoring icons, and vendoring makes license compliance very complicated. I'm not sure how problematic this is for Conda-Forge.
  • The CI is failing with the following, and I'm not sure why.
+ python .ci_support/build_all.py
Traceback (most recent call last):
  File "/Users/runner/work/1/s/.ci_support/build_all.py", line 213, in <module>
    check_recipes_in_correct_dir(root_dir, "recipes")
  File "/Users/runner/work/1/s/.ci_support/build_all.py", line 185, in check_recipes_in_correct_dir
    raise RuntimeError(f"recipe {path.parts} in wrong directory")
RuntimeError: recipe ('jupyterlab-spreadsheet-editor', 'meta.yaml') in wrong directory

So this may unfortunately take some effort to get running, but I don't have the time to work further on this.

from jupyterlab-spreadsheet-editor.

krassowski avatar krassowski commented on May 29, 2024

@maresb thanks for starting the work! Of course publishing it on conda-forge is very welcome! As for vendoring icons this should not be a problem.

It appears that you need to move the file into recipes/ directory, see for example https://github.com/conda-forge/staged-recipes/pull/14308/files where meta.yaml was added to recipes/jupyterlab-spellchecker/meta.yaml but you are adding directly to root (jupyterlab-spreadsheet-editor/meta.yaml)

Also, you may want to reuse parts of other recipes from jupyterlab-contrib, e.g. https://github.com/conda-forge/jupyterlab-spellchecker-feedstock/blob/main/recipe/meta.yaml

Please also add me as a maintainer :)

from jupyterlab-spreadsheet-editor.

maresb avatar maresb commented on May 29, 2024

Thanks @krassowski for the feedback! I did it in a big rush, so I'm not surprised there were mistakes. I did another very quick pass to address your points.

@drhagen, could you please comment on that PR (conda-forge/staged-recipes#22209) if you're willing to be maintainer?

from jupyterlab-spreadsheet-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.