Comments (3)
Adding a package to conda-forge is often as simple as running Grayskull to generate a PR in staged-recipes.
Anyone is welcome to clone my branch and fix things up to get this published on conda-forge.
A few initial observations:
- The linter is complaining about deleting
example/meta.yaml
but I obviously didn't delete it, so perhaps staged-recipes is temporarily in an inconsistent state. - This package is vendoring icons, and vendoring makes license compliance very complicated. I'm not sure how problematic this is for Conda-Forge.
- The CI is failing with the following, and I'm not sure why.
+ python .ci_support/build_all.py
Traceback (most recent call last):
File "/Users/runner/work/1/s/.ci_support/build_all.py", line 213, in <module>
check_recipes_in_correct_dir(root_dir, "recipes")
File "/Users/runner/work/1/s/.ci_support/build_all.py", line 185, in check_recipes_in_correct_dir
raise RuntimeError(f"recipe {path.parts} in wrong directory")
RuntimeError: recipe ('jupyterlab-spreadsheet-editor', 'meta.yaml') in wrong directory
So this may unfortunately take some effort to get running, but I don't have the time to work further on this.
from jupyterlab-spreadsheet-editor.
@maresb thanks for starting the work! Of course publishing it on conda-forge is very welcome! As for vendoring icons this should not be a problem.
It appears that you need to move the file into recipes/
directory, see for example https://github.com/conda-forge/staged-recipes/pull/14308/files where meta.yaml
was added to recipes/jupyterlab-spellchecker/meta.yaml
but you are adding directly to root (jupyterlab-spreadsheet-editor/meta.yaml
)
Also, you may want to reuse parts of other recipes from jupyterlab-contrib, e.g. https://github.com/conda-forge/jupyterlab-spellchecker-feedstock/blob/main/recipe/meta.yaml
Please also add me as a maintainer :)
from jupyterlab-spreadsheet-editor.
Thanks @krassowski for the feedback! I did it in a big rush, so I'm not surprised there were mistakes. I did another very quick pass to address your points.
@drhagen, could you please comment on that PR (conda-forge/staged-recipes#22209) if you're willing to be maintainer?
from jupyterlab-spreadsheet-editor.
Related Issues (20)
- Scroll to follow the active cell when moved with arrow keys
- Add text align buttons (editing centered text may be annoying)
- Enforce focus on search bar after ctrl + f
- Show how many rows/columns are selected on the statusbar
- Only scroll to cell if not already visible
- The highlight is not cleared after the content changes
- Could not support jupyterlab 3.0 HOT 1
- Adding/removing columns/rows from context menu does not update model
- Support parquet file format HOT 1
- Color column does not show colors properly if header row is enabled
- Text align HOT 1
- The default branch was renamed to `main` HOT 2
- Extra row added when saving a csv
- Support for JupyterLab 4.0 HOT 1
- Support for Jupyterlite HOT 6
- Incompatible with Python 3.12? HOT 1
- Releasing failed in "Finalize Release" step HOT 1
- DOC: update in-notebook spreadsheet widgets in README.md
- Prevent jumping after edit when in search mode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jupyterlab-spreadsheet-editor.