Serve a unique favicon.ico per project about jus

[billiegoose]

Oh boy! My identicon PR already is merged and on npm! :)

[billiegoose]

No code to merge yet, because I like being able to install jus and so we can't add 'identicon' as a dependency yet. But when we do, my code looks something like this:

// lib/server.js
const express  = require('express')
const cors     = require('cors')
...
const identicon = require('identicon')
const favicon   = require('serve-favicon')

var server = module.exports = express()
server.use(cors())

// Create unique favicon from the current working directory
var faviconPNG = identicon.generateSync({id: process.cwd(), size: 16})
server.use(favicon(faviconPNG))
...

[jdormit]

Looks good, but is there a check to serve an existing favicon if one exists?

[billiegoose]

Right, obviously an actual favicon.ico would take priority. I suppose that would mean putting server.use(favicon(faviconPNG)) farther down, as a fallback for the static server.

[zeke]

So this is just for development? Or do you also intend to kick out a default favicon in the build process if none exists?

[billiegoose]

I was just thinking of during development, to help me keep my tabs straight. Do you think people would want a defacto favicon in the built version?

[zeke]

Do you think people would want a defacto favicon in the built version?

Probably not. Just clarifying your intent. :)

[billiegoose]

How seriously do we take IE support? Apparently some browser STILL doesn't accept PNG favicons. There's a to-ico module that can convert a PNG buffer to an ICO buffer, but it'll drag in a bunch more dependencies.

Edit: Correction! I have maligned IE unjustly. It does take PNG favicons. It is just very VERY stubborn about caching favicons. (Had to delete the browser history to uncache them.)

[billiegoose]

Edit: Ignore my original grumpy old man statement. Feel free to discuss the feature / concept in this thread and critique the implementation in the pull request. Apparently in the grand scale of things that is supposed to make life less confusing.

(grump grump grump) Is there not a way to turn an existing issue into a pull request? I feel like the discussion should move to the pull request #63 but it's annoying that it's gonna fragment the conversation thread by doing that.

[zeke]

Is there not a way to turn an existing issue into a pull request?

Pretty sure you can still do it with https://hub.github.com/

[billiegoose]

Oh my. Googling that led to some loooong discussion threads. It sounds like the recommended practice is to separate concerns: issues for the bug / feature itself, pull-requests for the implementation details. Now I know, let's go with the flow. :)

[jdormit]

Merged in #63