A good trade was ignored about archisteamfarm

[JustArchi]

Thank you a lot for reporting this issue, I've managed to add unit test verifying that what you stated above is correct, and ASF behaviour was wrong.

When excessive amount of "missing amounts", so items in the set was missing on our side, there was a possibility for our logic to classify a good trade as bad one, because we didn't fill in enough holes, as the subtraction in the condition was calculated on each loop rather than once initially.

Since this could only worsen the neutrality score, but never improve it (as the amounts were sorted ascending), there was no abusive possibility due to that, only ignoring otherwise valid trades classifying them as worse than they were in reality.

Fixed in V6.0.3.1 which I'll release in a second.

[woctezuma]

Thank you! Have a nice week!

[JustArchi]

No need, I've confirmed it with unit test on our side. I have no clue what's wrong yet, but it's enough to move the issue forward.

[woctezuma]

I will try again without custom plugins later, but I don't expect a change of behavior.