GithubHelp home page GithubHelp logo

pdkit's People

Contributors

justinm avatar semantic-release-bot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

pdkit's Issues

Adding new dep via `devDependencies` via `.pdkitrc.ts` installs `*` version

Is this expected behaviour?

Added a dep:

diff --git a/.pdkitrc.ts b/.pdkitrc.ts
index a435330..5d7506b 100644
--- a/.pdkitrc.ts
+++ b/.pdkitrc.ts
@@ -13,6 +13,7 @@ const workspace = new YarnMonoWorkspace({
     "@types/mustache",
     "@types/node",
     "prettier",
+    "spdx-license-list",
     "ts-node",
     "typescript"
   ],

Ran yarn pdkit synth.

Result:

diff --git a/package.json b/package.json
index 9a93bc2..26a5550 100644
--- a/package.json
+++ b/package.json
@@ -57,6 +57,7 @@
     "jest-junit": "^13",
     "prettier": "2.6.2",
     "semantic-release": "^17.4.6",
+    "spdx-license-list": "*",
     "ts-jest": "27.1.4",
     "ts-node": "10.7.0",
     "typescript": "4.6.3"
diff --git a/yarn.lock b/yarn.lock
index 507b58b..aba9b48 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -9485,6 +9485,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"spdx-license-list@npm:*":
+  version: 6.6.0
+  resolution: "spdx-license-list@npm:6.6.0"
+  checksum: 180a7e940910ed68d4ee1e0c0ce34450ae048b353f4b71691caccd472267fd70dd2152e93cb6257505e0ab05f346d0c5917d533e2c6189b646a8836dd186a865
+  languageName: node
+  linkType: hard
+
 "split-on-first@npm:^1.0.0":
   version: 1.1.0
   resolution: "split-on-first@npm:1.1.0"
@@ -10834,6 +10841,7 @@ __metadata:
     mustache: 4.2.0
     prettier: 2.6.2
     semantic-release: ^17.4.6
+    spdx-license-list: "*"
     ts-jest: 27.1.4
     ts-node: 10.7.0
     typescript: 4.6.3

bug: `LICENSE` will not get updated when the content changes

new File(this, "Default", { filePath: "LICENSE", content: existingLicense?.toString() ?? this.content });

This part here uses existing file contents first, which means if the file exists, then the contents will never be updated.

content: existingLicense?.toString() ?? this.content

Maybe this is desirable for licenses not to change, but I am not sure.

However, from the technical side, it does go against the spirit of the projen approach, where it always clobbers the contents.

Still vague

What this project is for? The description is vague on use-cases. Please update readme! Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.