GithubHelp home page GithubHelp logo

Comments (3)

jrudolph avatar jrudolph commented on July 20, 2024

Thanks for the suggestions. What kind of issues did you have?

The reason that PERF_FLAME_OUTPUT defaults to the current directory is that the output file is a "real product" of the call so I wouldn't want it to default to a possibly transient directory.

from perf-map-agent.

nobeh avatar nobeh commented on July 20, 2024

I agree with the argument. Here is how I used the tool:

$ # clone the repo
$ # install
$ # did NOT create the symlinks
$ launch my app on a different term
$ cd /path/to/perf-map-agent
$ ./bin/perf-java-flames $PID

With the suggestions to resolve the real path of perf-map-agent, in the end, I got the result in root directory of perf-map-agent. I agree this is not critical and due to how I used the tool. However, I would also not want to pollute the git repo for perf-map-agent when using it.

Without the suggestions to resolve the real path of `perf-map-agent, I actually got an exception about failing to load the agent which makes sense because of how I used the tool.

from perf-map-agent.

jrudolph avatar jrudolph commented on July 20, 2024

I just found out that the script really was broken and it just worked for me before only because of an unclean work directory. I fixed it in the launcher script (adding the out directory) as you suggested and added extra diagnostic output to the Java attacher in case the library is missing.

Thanks for raising this issue.

from perf-map-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.