jwfoley / ingredients Goto Github PK

HTML/CSS lets you hide specified elements when printing the page, so take advantage of that to hide the reset buttons etc. https://stackoverflow.com/questions/355313/how-do-i-hide-an-element-when-printing-a-web-page

The individual_ingredient branch has a rough attempt to create adjustable inline ingredients. However, each one requires its own HTML form; I considered just making one big form for the whole thing but then the reset buttons won't work. And when the entire form is inline, it gets displayed as line breaks. I think I need to redesign all of this as a postprocessor rather than a preprocessor, so the lines are already formatted into HTML elements before I parse them, and then everything will be correctly nested - or at least instead of trying to cheat and scan for line breaks between elements, I can just look up to the parent.

Currently generate_ingredient_table takes an unparsed lxml.etree.Element with the ingredient text and parses that text, then returns a new Element with the appropriate table/form. Those steps could be separate functions, perhaps with the parsed ingredients stored in a better format than a list of lists (at least the inner ones ought to be tuples! maybe a namedtuple), which would also allow the higher-level Ingredients.run to intercept the parsed ingredients in order to accumulate a table of all ingredients used in all steps.

I implemented automatic total calculation, if all the ingredients in a table have the same unit, but I was too lazy to add local or global settings to suppress that feature if undesired.

I tried using markdown.markdown() to format the text inside an ingredient name, but it didn't work because it creates HTML tags like <strong>, which is then (correctly) interpreted by lxml as a child element rather than just plain text and I haven't allowed for that. I think this also means additional HTML tags inside the <ingredients> element would break it too. I haven't tried it in the current simple implementation of the direction list but that might not break as badly since it's not using <lxml>.