Comments (10)
It's a trivial fix. I have a pull request open (see #31 ), but because alert
is/was/has been (?) integrated as a core emacs package, I needed to assign copyright to the FSF, which I did, but they also wanted a letter from my employer which I was unable to get (despite spending many hours of writing explanations and responding to objections).
As I said, the actual fix is trivial - you can look at the pull request to see how trivial it is. (I'm happy for someone else to implement a fix - I hope to resolve the copyright assignment issue eventually, but who knows how long that may take).
from alert.
Interesting; it sounds like we should be passing along the fade time to notify-send
.
from alert.
Yes, that sounds like it would work.
from alert.
@emacsomancer Would you be interested in crafting a patch, after signing a copyright assignment with the Emacs project? I'm working now to include alert.el
into Emacs itself, and need those assignments to do so.
from alert.
@jwiegley I think it should be a fairly trivial patch; though my (e)lisp skills aren't great, but I've been wanting to improve those skills so this might be a good opportunity. Yes, I'm happy to sign the copyright assignment form.
from alert.
Isn't this just in alert-libnotify-notify
?
"--app-name" "Emacs"
"--hint" "int:transient:1"
;; HACK: Extra expire time
"--expire-time" (let ((fade-time (if (numberp alert-fade-time)
alert-fade-time
(car (get 'alert-fade-time 'standard-value))
)))
(number-to-string (* 1000 fade-time)))
from alert.
Hello,
I was running into this same issue and came across an old open issue here. Was wondering if there is an update..
from alert.
@jwiegley I would like to have this fixed upstream as well.
Anything I can do to get the PR by @emacsomancer merged? I could rewrite it. I have assigned copyright to the FSF in 2006 or so for Emacs Org-Mode. :-)
from alert.
Can you rewrite it without reading it?
from alert.
I fixed it on my local copy before I looked for an existent issue. So I wrote it without reading any other code.
from alert.
Related Issues (20)
- tmux-specific alert styles HOT 1
- [FR] Add severity "emoji icons"
- Minor mode to allow users to override the builtin `notifications-notify` command with `alert`?
- two 'ignore styles?
- alert-trivial-face foreground color "Dark Purple" is invalid?
- Alert always labels libnotify notifications as transient HOT 1
- post-command-hook alert-remove-on-command should not act during eval-expression
- Race Condition On mode-line Prevents (Meaningful) Restore
- alert broken using growl on Windows
- alert won't notify via notify-send HOT 2
- not working with Chinese or Emoji when style is osx-notifier HOT 1
- not working well with notifier style HOT 1
- :persistent doesn't work with libnotify HOT 5
- Support sounds
- Enhancement request: use https://github.com/KDE/snoretoast instead
- Feature request: ability to change app name
- Use `notifications-notify`, not `notify-send` command? HOT 1
- Parameter `:style` is not handled correctly HOT 2
- invalid-function: log4e:deflogger HOT 2
- alert-fade-time not working with osx-notifier
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alert.