Does install-jdk support Python 3.8? about install-jdk

[jyksnw]

Thanks @Maltiec that is super helpful. It looks like the type hinting on that method is causing the issues. I will get that corrected and a new release pushed out this week.

[jyksnw]

I just released 1.0.4 which resolves this issue. I am also going to open a new issue to set up something like nox along with some unit/sanity tests to test against versions 3.6+ and hopefully capture these failures before they hit release.

[jyksnw]

Hi @hx2A, I will need to look into this and get back to you. The library itself should be compatible with 3.6 and newer but I have had to upgrade the version support to 3.8.1 for some of the development dependencies. Do you you have any additional details on the error?

[hx2A]

Hi @jyksnw , this originated in a discussion thread in py5generator, as reported by @Maltiec. @Maltiec, can you provide additional information so we can fix this?

[Maltiec]

(py5coding_test) evgeniy@DigitalTrinity:~$ python --version
Python 3.8.16

(py5coding_test) evgeniy@DigitalTrinity:~$ pip install install-jdk
Collecting install-jdk
Downloading install_jdk-1.0.2-py3-none-any.whl (15 kB)
Installing collected packages: install-jdk
Successfully installed install-jdk-1.0.2

(py5coding_test) evgeniy@DigitalTrinity:~$ python -c "import jdk"
Traceback (most recent call last):
File "", line 1, in
File "/home/evgeniy/anaconda3/envs/py5coding_test/lib/python3.8/site-packages/jdk/init.py", line 10, in
from jdk.client import load_client
File "/home/evgeniy/anaconda3/envs/py5coding_test/lib/python3.8/site-packages/jdk/client/init.py", line 1, in
from jdk.client.adoptium import AdoptiumClient
File "/home/evgeniy/anaconda3/envs/py5coding_test/lib/python3.8/site-packages/jdk/client/adoptium.py", line 3, in
from jdk.enums import Architecture
File "/home/evgeniy/anaconda3/envs/py5coding_test/lib/python3.8/site-packages/jdk/enums.py", line 6, in
class BaseEnum(str, Enum):
File "/home/evgeniy/anaconda3/envs/py5coding_test/lib/python3.8/site-packages/jdk/enums.py", line 7, in BaseEnum
def contains(self: type[Enum], obj: object) -> bool:
TypeError: 'type' object is not subscriptable

[hx2A]

Thank you, and that sounds like a great plan.