Support node installed via nvm about commitplease

[jzaefferer]

@all3fox this would also be a good one. You could start by digging into the issue link, then we can discuss what we can do here.

[alisianoi]

I read the husky issue in jQuery and the linked issue in commitplease, here are my thoughts:

I tried to reproduce it on my machine: a simple project with commitplease and a 5.10.1 version of node installed via nvm. My commits to this project were being checked as expected. Then I bumped the node version:

nvm uninstall 5.10.1
nvm install 5.11
nvm use 5.11

Everything was still working. Ok, I cannot reproduce this issue with OS X El Capitan (10.11.3) on my machine (which runs Arch Linux). Another thing: I was doing git commit from the command line, not from a GUI app which mgol mentions. Basically, I could not reproduce his original steps.

The issue itself is addressed 59-87 of the husky repository. As I understand it, somehting similar should be done inside the commit-msg-hook.js of commitplease. But I do not feel comfortable doing this change because I cannot reproduce --- cannot know if I fix it or break it :(

Another option is to maybe make commitplease depend on husky. This will mean that husky provides all these git hooks as script options in package.json and commitplease then writes itself as such a script of package.json

[jzaefferer]

Okay, I'll see if I can reproduce this on my machine (I'm running OSX 10.11.4).

Meanwhile, I suggest you look at #33 and #34, try to implement both, then we can take those into consideration when designing the new validation options API to support the Angular style guide.

[jzaefferer]

Can't tell if this is still an issue, since its been a year, I'm closing.