Comments (3)
There's a list of valid keywords that GitHub accepts in #2. So "Closing" should indeed be rejected, since GitHub wouldn't recognise it.
The jQuery commit guidelines only list "Fixes" and "Closes", so while the first regex also looks for "Resolves", I reject that as well in the next regex.
That said, its quite possible that the regex can still be simplified. But at least your suggested fix seems wrong to me.
from commitplease.
This is on the line trying to detect mistakes. Your next line enforces the actual policy. I was just thinking through other cases you might want to detect, but given it's not valid for github perhaps you don't need to check for it. Sorry for suggesting.
from commitplease.
I think I now got what you were telling me. "Closing" is currently accepted as valid, but it shouldn't, right?
from commitplease.
Related Issues (20)
- [Bug] Husky hook erroring out HOT 7
- Optionally disallow "WIP", "Merge" ( and fixup! / squash!) HOT 3
- fixup! and squash! docs do not reflect actual behavior HOT 4
- scope required when it should be optional HOT 4
- Join forces with commitlint? HOT 8
- getProjectPath fails on Travis CI HOT 5
- Skip links for the length rule HOT 5
- Allow users to provide his own configuration
- Allow skipping of hook at install time HOT 1
- Allow Revert commits
- Support other presets?
- Should work with any of GitHub's closing keywords HOT 2
- Fail softer when not a git repo/no commits in git repo HOT 2
- Improve feedback flow HOT 10
- Generic Commit message pattern HOT 9
- Hook does not display errors HOT 11
- Using a word containing a keyword breaks the validation HOT 4
- Subsequent `git commit -m` get swallowed and ignored
- Display my own guidelines URL HOT 3
- [Request] Support skipping certain lines being linted for line length HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commitplease.