GithubHelp home page GithubHelp logo

Comments (3)

jzaefferer avatar jzaefferer commented on June 16, 2024

There's a list of valid keywords that GitHub accepts in #2. So "Closing" should indeed be rejected, since GitHub wouldn't recognise it.

The jQuery commit guidelines only list "Fixes" and "Closes", so while the first regex also looks for "Resolves", I reject that as well in the next regex.

That said, its quite possible that the regex can still be simplified. But at least your suggested fix seems wrong to me.

from commitplease.

bdowling avatar bdowling commented on June 16, 2024

This is on the line trying to detect mistakes. Your next line enforces the actual policy. I was just thinking through other cases you might want to detect, but given it's not valid for github perhaps you don't need to check for it. Sorry for suggesting.

from commitplease.

jzaefferer avatar jzaefferer commented on June 16, 2024

I think I now got what you were telling me. "Closing" is currently accepted as valid, but it shouldn't, right?

from commitplease.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.