GithubHelp home page GithubHelp logo

On-demand validation about commitplease HOT 2 CLOSED

jzaefferer avatar jzaefferer commented on June 18, 2024
On-demand validation

from commitplease.

Comments (2)

alisianoi avatar alisianoi commented on June 18, 2024

I have taken a closer look at grunt-commitplease

Currently, our commit-msg-hook.js uses the fact that it is either in node_module/commitplease or .git/hooks directory, so it can just go two levels up and get the .git/COMMIT_EDITMSG file. So, it can be run standalone with node node_modules/commitplease, like we do for jQuery Core. That will check the latest .git/COMMIT_EDITMSG (only the latest one) or fail if project history is empty.

So, I think here is what should happen. The instance of commit-msg-hook.js that gets copied to .git/hooks needs to get extra "check .npmrc for nohook" logic. The other instance that stays inside node_modules should get extra "let the user select a larger range of commits" logic (like in grunt-commitplease).

Tell me what you think, I am a bit confused how to do that at the moment.

from commitplease.

alisianoi avatar alisianoi commented on June 18, 2024

I'd say 2.7.x solves both the "validating commit range" and "better using .npmrc/package.json to skip hook"

from commitplease.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.