GithubHelp home page GithubHelp logo

Comments (6)

onedr0p avatar onedr0p commented on July 27, 2024 2

Hi @BungeBash sorry for the confusion on the chart updates but yes, additionalVolumes have changed if you are trying to move up to the next major version of a chart.

Here's a snippet from my https://github.com/onedr0p/home-cluster/blob/main/cluster/media/sonarr.yaml#L19 deployment:

    persistence:
      config:
        enabled: true
        storageClass: "rook-ceph-block"
        accessMode: ReadWriteOnce
        size: "25Gi"
    additionalVolumeMounts:
    - name: media-rocinante
      mountPath: "/media-rocinante"
    - name: media-serenity
      mountPath: "/media-serenity"
    additionalVolumes:
    - name: media-rocinante
      persistentVolumeClaim:
        claimName: nfs-media-rocinante-pvc
    - name: media-serenity
      persistentVolumeClaim:
        claimName: nfs-media-serenity-pvc

Feel free to look at the common library https://github.com/k8s-at-home/charts/blob/master/charts/common/values.yaml too.

from charts.

BungeBash avatar BungeBash commented on July 27, 2024

Much props! Thanks testing now

from charts.

onedr0p avatar onedr0p commented on July 27, 2024

Let me know, or close this issue if you don't have any further questions :)

from charts.

BungeBash avatar BungeBash commented on July 27, 2024

All resolved, thanks!

from charts.

windowsrefund avatar windowsrefund commented on July 27, 2024

@onedr0p
This response offers no real information as you're not explaining why you did what you did. Also, whatever you are doing here is not at all consistent with the default values.yaml files shipped with the *arr charts since they don't mention additionalVolumeMounts or additionalVolumes. The common library is so modular, requiring a fairly deep understanding of how exactly Helm charts work.... basically, it's obviously not "self documenting" in the way where it could be used as a handy reference.

So, I'd really like to reopen this thread. What exactly are the best practices related to using these charts against a RWX PVC? Even a detailed explanation between any common downloader (nzbget, transmission, whever else) and an indexer (sonarr, radarr, anything) would be valuable since everyone uses 1 of each category and would therefore, be able to substitute accordingly.

Ideally, something would be written and maintained on https://docs.k8s-at-home.com/ in order to get this knowledge out of this 'issues' area once and for all. Additionally, the values.yaml files would all be updated to include a link to that maintained documentation so people would know where to RTFM.

from charts.

bjw-s avatar bjw-s commented on July 27, 2024

The use of additionalVolumes will be removed in the upcoming major version of our common library. We have also added more (inline) documentation to our values.yaml. When it is released and you feel that there is still documentation missing, feel free to open a PR or an issue our repo's. We know docs are not our strongest area, but are always looking and working to improve.

As for explaining how/when to use RWX PVC's I think that goes beyond the scope of our project, since that is such a core Kubernetes concept.

Reopening this issue in order to discuss best practices doesn't seem like a good idea to me. Such discussions are best had in either our Discord or in our Github Discussions pages.

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.