Comments (4)
This is not a bug as we simply haven't yet supported adding custom labels to Ingress objects, as you can see by the code.
It would be relatively easy to add in an upcoming version of the chart.
from library-charts.
Sure, you are right.
values.yaml have labels inside the ingress and I have assumed it was implemented.
I don't know if this would be the right thing to do, but it has to be very approximate
kind: Ingress
metadata:
name: {{ $ingressName }}
labels:
{{- include "common.labels" . | nindent 4 }}
{{- with $values.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
{{- with $values.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
from library-charts.
Ooh, that's a very good catch... In that case we can classify it as a bug π
cc @onedr0p, since I'll be without my laptop for a short while
from library-charts.
I can take a look this weekend and hopefully get something out ππΌ
from library-charts.
Related Issues (20)
- StatefulSet missing `podManagementPolicy` HOT 1
- [common] Treat custom service ports as enabled by default
- externalTrafficPolicy is valid for type: NodePort HOT 3
- Generic ephemeral volume support HOT 1
- support binaryData for persistence.* of type configMap HOT 2
- Add option to allow usage of Helm Templates in all values of `values.yaml` file items HOT 2
- Add option for generic Persistent volume claims HOT 3
- Add tailscale sidecar support
- persistence.name does not apply fullname for configMap names HOT 2
- ability to add a ca-bundle via common library HOT 1
- Misspelling HOT 1
- Global labels HOT 1
- [common] I'd like cert-manager Issuer creation and management to be centralized HOT 3
- Remove HorizontalPodAutoscaler
- typo in HPA annotations HOT 7
- Secrets defined an array with a valuesFrom get a duplicate name
- [common] Ingress fails to deploy with named service port HOT 1
- Add LoadBalancer IP to service template HOT 1
- [common] Cannot deploy services with type ExternalName HOT 1
- Deprecation of this Repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from library-charts.