Comments (11)
Thanks for working on this @mvalarh!
Perhaps next Monday (when we do our regular push) we can contrive a scenario to test this. Let me know if this would work:
- Prepare: merge a PR removing a user from ci.yaml. It will be @abutcher's turn on rotation next week, so if he agrees, we can experiment on him :P
- Andrew submits the week's PR as usual. Since he's no longer in ci.yaml, it won't be approved.
- Have someone who's still in ci.yaml (e.g. me) approve the PR
- ...and IIUC at this point we have to nudge the PR somehow? Either hold->unhold, draft->ready, or Andrew pushes an update?
- Clean up: Restore Andrew to ci.yaml.
Will that be an effective test?
from community-operators.
* When adding an authorized user to ci.yaml (e.g. [1](https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/63), [2](https://github.com/k8s-operatorhub/community-operators/pull/65)), a repo admin still needs to participate to get the PR merged. It would be cool if pre-existing reviewers in ci.yaml could have that power (via `/lgtm` or `/approve` or whatever).
We were already allowing it, but it is not working. The problem is that when user (authorized user) would do the comment (via /lgtm or /approve or whatever) then workflow comment handler is executed with that user's permissions and if that user (authorized user) doesn't have write access to repo (by default no one has) then label cannot be set by that user. Only repo admin can. I am still thinking about this feature (not high priority). But you can give me hint if you have some proposal.
from community-operators.
* When a test fails, even an authorized (via ci.yaml) user can't seem to [retest](https://github.com/k8s-operatorhub/community-operators/pull/75#issuecomment-891143786) or [add ok-to-test](https://github.com/k8s-operatorhub/community-operators/pull/75#issuecomment-891148861).
To retest one can do:
- convert issue to draft
- click on "Ready for review"
from community-operators.
Feel free to reopen
from community-operators.
@2uasimojo I just implemented feature with authorized_label when PR is approved by reviewer. Let me know when you will have such PR so we can test it. Thanks
from community-operators.
Possible workflows
- approve
/hold
/unhold
or
- approve
- author will push something
or
- approve
- make
draft
Issue Ready for review
Note: We always rely on information that of last github reviewer and it hase to be in state APPROVED
from community-operators.
We tested this via #324 (to remove abutcher from reviewers) and #326 (which he submitted and I approved). It works! Thanks @mvalarh!
We're going to test a different flow -- say the draft/ready one? -- by having Andrew submit the PR to restore himself to ci.yaml.
from community-operators.
It seems like when the submitter is not a reviewer, the bot puts a /hold
on the PR anyway. So the hold-unhold flow is kind of kicked off by default.
from community-operators.
Bot is putting in hold only in case ci.yaml
is changed
from community-operators.
@mvalarh I'm happy with the functionality as we tested it. If you'd like us to test some other permutation, let us know. Otherwise I'm happy to close this issue.
from community-operators.
Documentation is located : https://k8s-operatorhub.github.io/community-operators/self-merge-updates/#how-do-i-approve-pr
from community-operators.
Related Issues (20)
- [test_operator_update : Logs] should be skipped if no update is being performed HOT 1
- sealed-secrets-operator-helm is deprecated maybe remove from OperatorHub? HOT 1
- operator release pipeline is failing at OHIO stage HOT 4
- Percona Postgres operator install mode HOT 4
- PR title expects "operators" instead of "operator" HOT 2
- Skipping e2e for tektoncd-operator (0.60.0) HOT 5
- Support for persistent volume mounted to Operator HOT 4
- Remove Sysdig Operator HOT 1
- Task failed from orange test suite: TASK [operator_index : Remove ] HOT 2
- Create custom catalogs using this repo HOT 2
- How to modify an already merged operator? HOT 2
- Orange test failing while checking for registry in default namespace HOT 4
- Local testing for operator fails. HOT 2
- Update tektoncd version HOT 2
- Build failure: OHIO image / k8s HOT 2
- Allow for metadata file to be added to directory structure HOT 3
- `updateGraph: semver-mode` not working for cross-channel upgrade HOT 2
- Operator Life Cycle Manager: Prometheus Operator Install Fails: file monitoring.coreos.com_prometheusagents.yaml bigger than total allowed limit HOT 3
- Keycloak operator v22.0.4 deploy Keycloak nightly by default HOT 2
- hybrid-cloud-patterns.io seems deprecated for validatedpatterns.io HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from community-operators.