GithubHelp home page GithubHelp logo

Comments (7)

rodrigore avatar rodrigore commented on August 27, 2024 1

Yes... thanks for the help.

from nova-impersonate.

AndreSchwarzer avatar AndreSchwarzer commented on August 27, 2024

I can not verify this bug.
What are the steps to reproduce it?
I took a fresh installation of Laravel 5.7 and Nova 1.3.0 and 1.0.8 of this project.

screenshot 2019-01-15 at 17 23 36

from nova-impersonate.

rodrigore avatar rodrigore commented on August 27, 2024

The steps is basically impersonate an user, and then send a the notification.

Works fine when Im not impersonating the user.

from nova-impersonate.

AndreSchwarzer avatar AndreSchwarzer commented on August 27, 2024

I cannot reproduce it: https://youtu.be/4mO31Kdd8fU

The /test-notification blade is the default home.blade.php. I replaced the "You are logged in" with the auth()->user()->name and added the following to the bottom of the blade (quick and dirty).

<?php
\Illuminate\Support\Facades\Notification::send(auth()->user(), new \App\Notifications\TestNotification());
?>

All the Notification does is:

    public function toMail($notifiable)
    {
        return (new MailMessage)
                    ->line('The introduction to the notification.')
                    ->line('Your Name: '. $notifiable->name)
                    ->action('Notification Action', url('/'))
                    ->line('Thank you for using our application!');
    }

from nova-impersonate.

rodrigore avatar rodrigore commented on August 27, 2024

Wow, thanks for the video.

I just try with 'mailtrap' and the 'reverse.blade' is hide.

The problem was that I was viewing the mail in Laravel telescope.

Thanks again!.
screen shot 2019-01-15 at 14 13 34
screen shot 2019-01-15 at 14 14 01

from nova-impersonate.

AndreSchwarzer avatar AndreSchwarzer commented on August 27, 2024

So this Issue can be closed?

This seems not to be a bug of this packages, more like some unique edgecase telescope doesn't (IMHO: have to) handle.

from nova-impersonate.

KABBOUCHI avatar KABBOUCHI commented on August 27, 2024

Maybe we can add a configurable exception array on the middleware

https://github.com/laravel/laravel/blob/915667a8d5fa31e7d35b617f64c47ab67a64a171/app/Http/Middleware/VerifyCsrfToken.php#L16-L23

from nova-impersonate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.