GithubHelp home page GithubHelp logo

Comments (7)

KABBOUCHI avatar KABBOUCHI commented on August 27, 2024 1

I think we should implement it like this:

  • Add config option to enable multi-guard feature
  • Add config option for all available guards (defaults: ['web','api'])
  • Modify the JS to display popup to choose the guard if multi-guard enabled

from nova-impersonate.

ralphschindler avatar ralphschindler commented on August 27, 2024 1

Also, leaving does not appear to work, but I will debug that.

can you create a small prj/repo to test it?

It was a configuration issue, I had to change the "leave" middleware to also include nova.

This appears to work well now, feel free to cut a release! :)

from nova-impersonate.

ralphschindler avatar ralphschindler commented on August 27, 2024

Whats the status of this? Will you entertain a PR that gets up to 1.4?

from nova-impersonate.

KABBOUCHI avatar KABBOUCHI commented on August 27, 2024

I pushed this feature to the master branch, please can you test it?

composer require kabbouchi/nova-impersonate:dev-master
php artisan vendor:publish --tag=nova-impersonate-config

then enable multi-guard in config/nova-impersonate.php and add your guards too.

<?php
return [
/*
* Enable multi-guard feature
*/
'enable_multi_guard' => false,
/*
* The default impersonator guard used.
*/
'default_impersonator_guard' => 'web',
/*
* Impersonator guards to be used.
*/
'impersonator_guards' => ['web'],

from nova-impersonate.

ralphschindler avatar ralphschindler commented on August 27, 2024

This appears to work; would love to see it as a release! Thanks!

Although- why not use the configuration from config/laravel-impersonate.php 'default_impersonator_guard' => 'web',?

Also, leaving does not appear to work, but I will debug that.

from nova-impersonate.

KABBOUCHI avatar KABBOUCHI commented on August 27, 2024

@ralphschindler thanks for your help

Although- why not use the configuration from config/laravel-impersonate.php 'default_impersonator_guard' => 'web',?

to avoid managing 2 config files

Also, leaving does not appear to work, but I will debug that.

can you create a small prj/repo to test it?

from nova-impersonate.

KABBOUCHI avatar KABBOUCHI commented on August 27, 2024

v1.1.2 has been released

from nova-impersonate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.