Comments (7)
I think we should implement it like this:
- Add config option to enable
multi-guard
feature - Add config option for all available guards (defaults:
['web','api']
) - Modify the JS to display popup to choose the guard if
multi-guard
enabled
from nova-impersonate.
Also, leaving does not appear to work, but I will debug that.
can you create a small prj/repo to test it?
It was a configuration issue, I had to change the "leave" middleware to also include nova
.
This appears to work well now, feel free to cut a release! :)
from nova-impersonate.
Whats the status of this? Will you entertain a PR that gets up to 1.4?
from nova-impersonate.
I pushed this feature to the master branch, please can you test it?
composer require kabbouchi/nova-impersonate:dev-master
php artisan vendor:publish --tag=nova-impersonate-config
then enable multi-guard in config/nova-impersonate.php
and add your guards too.
nova-impersonate/config/nova-impersonate.php
Lines 1 to 16 in 31fd5b7
from nova-impersonate.
This appears to work; would love to see it as a release! Thanks!
Although- why not use the configuration from config/laravel-impersonate.php
'default_impersonator_guard' => 'web',
?
Also, leaving does not appear to work, but I will debug that.
from nova-impersonate.
@ralphschindler thanks for your help
Although- why not use the configuration from config/laravel-impersonate.php 'default_impersonator_guard' => 'web',?
to avoid managing 2 config files
Also, leaving does not appear to work, but I will debug that.
can you create a small prj/repo to test it?
from nova-impersonate.
v1.1.2 has been released
from nova-impersonate.
Related Issues (20)
- Add support for Laravel 9
- Project upgraded to Laravel 9 - impersonate stopped working HOT 5
- Nova v4 support HOT 4
- Impersonate interfere with a nova-filepond package HOT 4
- User impersonates student, is it possible?
- Nova 4: typing 'i' in the search impersonates the first user HOT 4
- Rendering Impersonate field yields PHP deprecation notice HOT 1
- Difference between native Impersonate Nova4 feature and this package? HOT 3
- How to add style to impersonate on fields ?
- Nova-Impersonate shows twice on resource index HOT 1
- 404 when trying to impersonate HOT 3
- Route [login] not defined when leaving impersonating mode after session expired and click "Leave impersonating" HOT 5
- Tag last release HOT 1
- Feature request: Add impersonation interface and don't force 404labfr HOT 3
- Please Use a Legal Icon [Invalid βΒ User Error!] HOT 2
- Missing user provider for guard null
- Feature Request: Add Impersonate option to Lenses HOT 2
- Impersonate button not showing when using Laravel Octane HOT 4
- Remove Shortcut Key "I" on View Page? HOT 2
- Maintain Nova Accessibility Of Impersonating User
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nova-impersonate.