GithubHelp home page GithubHelp logo

Comments (10)

m1ome avatar m1ome commented on May 21, 2024

Version 1.0.0 is fine.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

It's bug in 1.0.6 checked and 1.0.5 passed test.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

I think 1225503 can break a BC.

from kahlan.

jails avatar jails commented on May 21, 2024

Weird, I'm not able to reproduce. https://github.com/jails/temp/commit/bd61dcdaf2380905ecf6f9ff4f7baa102afe441d gives https://travis-ci.org/jails/temp/jobs/51644921 so looks like the method is corrected intercepted in the above example.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

How can i dump stubbed methods or something else? To provide more debug info.

from kahlan.

jails avatar jails commented on May 21, 2024

Stub::registered() should return all stubbed methods but if there's a glitch somewhere, the easier way would be to clone https://github.com/jails/temp (the dev branch) and tweak it to reproduce your actual issue on it because I probably missed something somewhere since I wasn't able to reproduce it.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

I'll try it tomorrow.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

Found it, it was not BC but, a strange work.
I have a code:

$args->set('include', [
  'Api'
]);

And before 1.0.6 it worked fine, but my base model is inside Spec\Helper in 1.0.6 i add:

$args->set('include', [
  'Api',
  'Spec\Helper',
]);

And it work.

from kahlan.

jails avatar jails commented on May 21, 2024

Ah indeed, it's probably related to this commit 03c910c
All $args->set() calls in config files was just ignored before this commit. Previously the only option to "set" a specific value to an argument was to override its defaults values using $args->argument(). And the fact that $args->set() is now working as expected was probably the origin of your issue.

from kahlan.

m1ome avatar m1ome commented on May 21, 2024

I think so. It's not a BC break, more like correct work. Thanks.

from kahlan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.