GithubHelp home page GithubHelp logo

Comments (12)

kakaroto avatar kakaroto commented on June 2, 2024 2

I'm trying to add Elven Accuracy, but it's a though one because D&D Beyond doesn't tell me what the ability is when you do an attack, so I'd have to add a lot of logic into the extension itself to determine if dexterity is used for weapons or strength, or what class a spell is coming from and what ability is used for attack for that class to determine if Elven Accuracy would count. Also, it would only work if you select "roll with advantage", if you use "always roll twice" then should I also do it ? Also, Roll20 doesn't allow to specify more than 2 rolls for attack. Lucky feat is similar too I guess, though you make the decision after you roll.
I'll leave it for now in the list of special things to handle, but I'm not making it a priority. In those cases, I think it makes more sense to determine in advance with the DM that the damages from the first roll are to be used and to re-roll only to get the additional 'to-hit' result and ignore the rest.

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024 1

Cool thanks for letting me know, I'll add support for it!

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

Added Improved Crticial and Brutal Critical to the list

from beyond20.

jekface avatar jekface commented on June 2, 2024

Hi, first of all, awesome job! Found an issue I think might need some work. Monk special skill for deflecting missiles. The roll is supposed to add Dex and monk level. It just rolls the d10 without bonuses. Anyway, thanks for this extension. Great job!! I love it.

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

Deflect Missiles should work now (only if clicked from D&D Beyond, not from within the roll20 description). Same with other features that have "+ your modifier" or "+ your level", such as Second Wind.

from beyond20.

further-reading avatar further-reading commented on June 2, 2024

Hey man, I love this extension! I've been working on my own version but yours blows all my work out of the water.

Had some issues though today when using it with my monk:

  • Monk unarmed attacks seem to use the static default damage instead of their special damage die.
  • There doesn't seem to be a way to roll tool use - I expect this is because the dndbeyond card doesn't give the roll info.

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

@further-reading hey thanks! I just saw your dndbeyond scraper. I don't know if you're aware, but you can take any character URL in D&D Beyond and add '/json' to the URL to get the full character sheet in a json format! It might be easier than trying to parse the html :)

1 - I'm not sure about that. I can see that D&D Beyond already shows the unarmed attack as 1d4 + DEX in the case of my monk character and the right dice is rolled. Normally it would be 1 + STR.
2 - Yeah, that's a D&D Beyond issue, What I do is create a custom skill for any tools, like Thieve's tools for example, Beyond20 already supports it and if you don't specify the ability for the custom skill, it will query it in the R20 window.

from beyond20.

further-reading avatar further-reading commented on June 2, 2024

Oh wow, that's a great fix for the tools proficiency issue!

For my Monk I had a another test and it seems to be something to do with the custom damage option. Before I used it the roll worked properly but then after it was set it stopped rolling my Monk damage die. My Monk also has a negative strength modifier which might have impacted it too(it'd make the default damage 0)? Character sheet is here if you wanna try https://www.dndbeyond.com/profile/Further_Reading/characters/10371377

As an aside about the scraper, I know about the json but a main reason behind it is practice - I like to learn new techniques by using them to make something in my life easier so this seemed like a fun way to learn webscraping! :P

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

Oh you're right, my bad! it was fine for attacks and spells but for 'actions' I had it set to replace the damage instead of appending to it. All fixed now.
For the scraper, I figured as much considering the project description/README, but thought it was worth mentioning. I think it's a great project idea to get some practice!

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

Add Great Weapon Fighting. Reroll on a 1 or 2 on two-handed weapons. R20 uses '1d8ro<2' to do the re-roll once.

from beyond20.

SANSd20 avatar SANSd20 commented on June 2, 2024

Also, how about Elven Accuracy? Most for the "Whenever you have advantage on an attack roll using Dexterity, Intelligence, Wisdom, or Charisma, you can reroll one of the dice once."

from beyond20.

kakaroto avatar kakaroto commented on June 2, 2024

Closing this issue at this point. Future special features should get their own issues created

from beyond20.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.