build issue for src/online about kaldi

[danpovey]

Let's wait till we get some other comments on this.
@jtrmal ?

[jtrmal]

That will solve problems for you, but will create problems for users that
do not have compiled portaudio against jack, I believe.
The correct solution would be, perhaps, use pkg-config? I'm not sure if we
can rely on its presence, though.
y.

On Fri, Oct 9, 2015 at 7:12 PM, Daniel Povey [email protected]
wrote:

Let's wait till we get some other comments on this.
@jtrmal https://github.com/jtrmal ?

—
Reply to this email directly or view it on GitHub
#221 (comment).

[dwks]

It's strange. The pkg-config for portaudio doesn't list -ljack as a dependency even when it was built with jack support (which is the default if libjack-dev installed). It only shows

$ pkg-config --libs ../../tools/portaudio/install/lib/pkgconfig/portaudio-2.0.pc 
-L.../tools/portaudio/install/lib -lportaudio -lasound -lm -lpthread 

So this doesn't solve the linker errors:

EXTRA_LDLIBS += $(shell pkg-config --libs ../../tools/portaudio/install/lib/pkgconfig/portaudio-2.0.pc)

Given the way the Makefile checks for alsa, here is a symmetric method for jack:

diff --git a/src/online/Makefile b/src/online/Makefile
index 4c0ad9f..3e1c7ca 100644
--- a/src/online/Makefile
+++ b/src/online/Makefile
@@ -22,6 +22,9 @@ ifeq ($(UNAME), Linux)
   else
     EXTRA_LDLIBS += -lrt
   endif
+  ifneq ($(wildcard ../../tools/portaudio/install/include/pa_jack.h),)
+    EXTRA_LDLIBS += -ljack
+  endif
 endif

There must be a better way however.

[dogancan]

Some time back I was struggling with this exact problem and the best solution I found at the time was to parse the portaudio libtool file after installation (tools/portaudio/lib/libportaudio.la) to figure out the library dependencies as well as linker flags on different platforms. The particular variables of interest are "dependency_libs" and "inherited_linker_flags".

[dwks]

Looks like a portaudio bug. The configure.in doesn't say it needs -ljack in its pkg-config for unix even though it does for windows; it just needs a LIBS="$LIBS $JACK_LIBS". I have reported it to the portaudio developers.

For kaldi, my earlier diff is probably sufficient unless we want to switch to pkg-config.

[danpovey]

I'll put it as a comment in the Makefile for now.
Dan

On Fri, Oct 9, 2015 at 8:09 PM, dwks [email protected] wrote:

Looks like a portaudio bug. The configure.in doesn't say it needs -ljack
in its pkg-config for unix even though it does for windows; it just needs a
LIBS="$LIBS $JACK_LIBS". I have reported it to the portaudio developers.

For kaldi, my earlier diff is probably sufficient unless we want to switch
to pkg-config.

—
Reply to this email directly or view it on GitHub
#221 (comment).

[dwks]

I meant this diff which should be safe.

+  ifneq ($(wildcard ../../tools/portaudio/install/include/pa_jack.h),)
+    EXTRA_LDLIBS += -ljack
+  endif

[danpovey]

Ok, I'll add that, thanks.

On Fri, Oct 9, 2015 at 8:29 PM, dwks [email protected] wrote:

I meant this diff which should be safe.

• ifneq ($(wildcard ../../tools/portaudio/install/include/pa_jack.h),)
• EXTRA_LDLIBS += -ljack
• endif

—
Reply to this email directly or view it on GitHub
#221 (comment).

[dwks]

The portaudio folks don't seem to be fixing this right away. Let's just stick with what we already have. Closing the issue.