GithubHelp home page GithubHelp logo

Comments (13)

KalebKE avatar KalebKE commented on August 15, 2024 1

@allyouaskfor

I am still working on your issue. I have to reverse engineer some bit fields from tuner pro to handle the matrix transformations correctly and I haven't found the time yet, but hopefully this weekend I will get a chance to work on it.

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@allyouaskfor

Can you kindly provide your XDF file and binary? I will take a look.

from me7tuner.

allyouaskfor avatar allyouaskfor commented on August 15, 2024

Here is a zip containing the binary along with XDF.
allyouaskfor-ME7Tuner.zip

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@allyouaskfor

Thank you. I should have time to look at it this week.

from me7tuner.

run4x avatar run4x commented on August 15, 2024

Could this be related to regional settings? Dot vs comma as decimal separator.

I tried v1.0.3 on MBP (Monterey) and on Win10, both with non-US region and had similar issue as @allyouaskfor
Then did a quick check on Win11 with US region and was able to set the maps in configuration.

With v1.0.4 I can select and set maps from xdf, but cannot open most of the tabs.

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@run4x

Thanks for that information. I'll take a look. I may not be setting a default local XML parser.

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@allyouaskfor

I see the issue. I haven't implemented functionality for the 'scalar link'. Your XDF is the first I have seen where this is used.

The tag for scalar link will embed in an tag... something like:

<embedinfo type="3" linkobjid="0x314C" />

However, some of your tags are also embedded with the pure internal axis tag which looks like:

<EMBEDDEDDATA mmedtypeflags="0x02" mmedaddress="0x139AA" mmedelementsizebits="16" mmedcolcount="12" mmedmajorstridebits="16" mmedminorstridebits="0" />

The tag ends up pointing to what is effectively another table definition that I need to parse to eventually get to the desired axis.

It seems like the expected behavior here is that if the exists it overrides the pure internal axis? e.g, if you have a scalar link defined you expect it to defer to that address and ignore the pure internal address? It appears that tuner pro works this way.

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@allyouaskfor

There seems to be some junk conversions in the XDF file as well: where '0.114843.375' is not a number.

<XDFCONSTANT uniqueid="0x2348">
    <title>Minimum Possible AFR Request</title>
    <CATEGORYMEM index="0" category="12" />
    <CATEGORYMEM index="1" category="56" />
    <EMBEDDEDDATA mmedtypeflags="0x02" mmedaddress="0x19156" mmedelementsizebits="8" mmedmajorstridebits="0" mmedminorstridebits="0" />
    <datatype>28</datatype>
    <unittype>0</unittype>
    <DALINK index="0" />
    <MATH equation="0.114843.375 * X">
      <VAR id="X" />
    </MATH>
  </XDFCONSTANT>

from me7tuner.

allyouaskfor avatar allyouaskfor commented on August 15, 2024

I appreciate that information. Thanks for looking over it. The XDF is not one that I created myself but seeing that the issue is within the XDF, I will create a new one containing only the variables required to use ME7Tuner. I'll test that out on my Macbook as soon as i can. Is there anything else I can do to help?

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@allyouaskfor

I do think I have the linking working, but I am having a hard time testing it due to the bad data in some of the unrelated tables. If you could get me a cleaned up (and potentially narrower) version of the XDF if would be helpful.

from me7tuner.

run4x avatar run4x commented on August 15, 2024

@KalebKE could you test the decimal separator (regional settings) issue with stock 551K bin and this short xdf attached?
551K-me7tuner.zip
Can you open all tabs and use the functionality as expected?
I can set the configuration, but cannot use the app at all.

from me7tuner.

KalebKE avatar KalebKE commented on August 15, 2024

@run4x

I have defaulted the locale to English in #19.

I did test your bin and XDF and it does work with the English locale and does not work with the German locale. I expect this will resolve your issues. Please re-open #19 if you continue to have issues.

Release: https://github.com/KalebKE/ME7Tuner/releases/tag/v1.0.5

from me7tuner.

allyouaskfor avatar allyouaskfor commented on August 15, 2024

I appreciate all the work you're putting into this. Sorry that I haven't gotten you a slimmer XDF yet. I've been busy with work but I do still have the intention on getting that done. Thank you.

from me7tuner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.