GithubHelp home page GithubHelp logo

Comments (16)

dubek avatar dubek commented on June 25, 2024

Guile fix in #124.

from mal.

kanaka avatar kanaka commented on June 25, 2024

I'll work on julia

from mal.

kanaka avatar kanaka commented on June 25, 2024

I'll take scala too.

from mal.

kanaka avatar kanaka commented on June 25, 2024

Okay, julia and scala fixes pushed. Also, I added some nested hash-map tests in addition to the nested sequences tests.

from mal.

kanaka avatar kanaka commented on June 25, 2024

I updated the list with all the implementation that fail the new nested equality tests (including forth and kotlin which are missing hash-map equality entirely).

from mal.

kanaka avatar kanaka commented on June 25, 2024

Fix bash and PHP in: 33d33bb (silly bugs really)

from mal.

kanaka avatar kanaka commented on June 25, 2024

Haskell was an easy fix too.

from mal.

ivern avatar ivern commented on June 25, 2024

Kotlin should be updated to fixed now that it's merged.

from mal.

kanaka avatar kanaka commented on June 25, 2024

@jordanlewis @nlfiedler @ekmartin factor, erlang, and elixir are the remaining languages that still need this fix. Could you look at your respective implementation and fix the equality test when a sequence is embedded in another sequence? In other words, make these forms return true?

(= [(list)] (list []))
(= [1 2 (list 3 4 [5 6])] (list 1 2 [3 4 (list 5 6)]))

Thanks!

from mal.

jordanlewis avatar jordanlewis commented on June 25, 2024

Sure I will take a look at this.

from mal.

ekmartin avatar ekmartin commented on June 25, 2024

Sure, I'll take a look.

from mal.

kanaka avatar kanaka commented on June 25, 2024

Just factor left now.

from mal.

kanaka avatar kanaka commented on June 25, 2024

@jordanlewis don't worry about factor since @dubek just fixed it.

from mal.

kanaka avatar kanaka commented on June 25, 2024

Final thing is making the tests not soft tests. I just pushed that and will close this once travis gives the green light: https://travis-ci.org/kanaka/mal/builds/106320895

from mal.

jordanlewis avatar jordanlewis commented on June 25, 2024

Thanks @dubek!

from mal.

kanaka avatar kanaka commented on June 25, 2024

All green. Closing.

from mal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.