Keyword equals is false about mal

[ktodyruik]

FYI, I noticed this in the 'issue_166_string_ops' branch as I was trying out the new string functions.

[kanaka]

@ktodyruik I'm not seeing that behavior. Are you certain you are on the most recent version of the branch (what git hash are you testing against)? Also, what version of mono do you have?

[ktodyruik]

I built it using .NET 4.0 on Windows (not mono), and I checked out the
issue_166_string_ops branch.

Kerry

On Wed, Feb 17, 2016 at 8:20 AM, Joel Martin [email protected]
wrote:

@ktodyruik https://github.com/ktodyruik I'm not seeing that behavior.
Are you certain you are on the most recent version of the branch (what git
hash are you testing against)? Also, what version of mono do you have?

—
Reply to this email directly or view it on GitHub
#177 (comment).

[ktodyruik]

I just tried it with the main branch. The issue appears to be in the _equal_Q type comparison.

[kanaka]

@ktodyruik interesting. But all the other tests work for you? For the statement (= kw :abc) you shouldn't be getting a MalSymbol passed to the _equal_Q function because the symbol should have been resolved to it's value from the environment (unless you intentional quote the symbol). I don't see that behavior myself with mono on Linux so I don't have a way to reproduce it in order to debug and come up with a fix. If it really is getting passed _equal_Q as a symbol, then the problem is more likely to be in eval_ast (where symbols are resolved in the environment) or EVAL (which sets up the call to eval_ast).

Also, are you using an unmodified source tree and are those complete (and only) commands that you ran? I only ask because the prompt should be user> and not >.

[ktodyruik]

@kanaka Thanks. Good suggestions. I have been playing around with the source code. I'll make sure I'm testing on a clean copy and take a closer look.

[ktodyruik]

@kanaka I just ran it on a fresh copy and it worked correctly. So I caused the bug somehow. Sorry to trouble you. :)

[kanaka]

@ktodyruik glad you figured it out.

[ktodyruik]

@kanaka I see my mistake now. I tried to create an alias from = to eq?. This was executed prior to the above equals expression.

I mistakenly wrote

(defmacro! eq? =)

instead of

(def! eq? =)

This caused the _equal_Q function to be a macro. Then, EVAL called macroexpand which evaluated the expression to false.