GithubHelp home page GithubHelp logo

Comments (5)

kantlivelong avatar kantlivelong commented on July 23, 2024 2

Would likely just update the README.md as it's already a bit dated by now.

from octoprint-psucontrol.

agreen avatar agreen commented on July 23, 2024

I basically have a PR ready to go for this, however I wanted feedback from you. I have to make one assumption to get it to work right... If you're using an optocoupler and inverting the signal (so that ground is on, and "not ground" is off)... You either need to use an external pullup resistor, or enable internal pullup. What's your thought on enabling internal pullup/down depending on invert sense state? I think it might make the code a bit "safer".. and would still work if there was an external pullup/down.

from octoprint-psucontrol.

kantlivelong avatar kantlivelong commented on July 23, 2024

I'd personally prefer another option next to the invert checkbox as a dropdown to specify NONE, PUD_UP, PUD_DOWN.

  • No Internal Pull-Up/Down
  • Internal Pull-Up
  • Internal Pull-Down

from octoprint-psucontrol.

agreen avatar agreen commented on July 23, 2024

Will do. I'll get that added. Spent a few hours last night scratching my head as to why it wasn't working before I realized. Also, it's something that should probably be documented onscreen or somewhere. i.e.
Suggested values:
not inverted = internal pull-down
inverted = internal pull-up

from octoprint-psucontrol.

kantlivelong avatar kantlivelong commented on July 23, 2024

PR Merged

from octoprint-psucontrol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.