Comments (5)
Would likely just update the README.md as it's already a bit dated by now.
from octoprint-psucontrol.
I basically have a PR ready to go for this, however I wanted feedback from you. I have to make one assumption to get it to work right... If you're using an optocoupler and inverting the signal (so that ground is on, and "not ground" is off)... You either need to use an external pullup resistor, or enable internal pullup. What's your thought on enabling internal pullup/down depending on invert sense state? I think it might make the code a bit "safer".. and would still work if there was an external pullup/down.
from octoprint-psucontrol.
I'd personally prefer another option next to the invert checkbox as a dropdown to specify NONE, PUD_UP, PUD_DOWN.
- No Internal Pull-Up/Down
- Internal Pull-Up
- Internal Pull-Down
from octoprint-psucontrol.
Will do. I'll get that added. Spent a few hours last night scratching my head as to why it wasn't working before I realized. Also, it's something that should probably be documented onscreen or somewhere. i.e.
Suggested values:
not inverted = internal pull-down
inverted = internal pull-up
from octoprint-psucontrol.
PR Merged
from octoprint-psucontrol.
Related Issues (20)
- Latest OctoPrint update broke the "Automatically turn PSU OFF when idle" HOT 17
- Feature request. HOT 4
- PSUControl doesn't work or is inconsistent in Docker installation HOT 2
- Feature request won't work (Temperature failsafe)
- Feature request: Automatic pre-heat on power up setting
- Feature Request. PreOff/ Pre Disconnect Timer
- Feature Request Page is Down
- Printing is extraordinarily slow/problematic if networked power switch unavailable HOT 3
- `Turn off when an unrecoverable firmware or communication error occurs` does not work on serial exception HOT 1
- [Request] : is there a shutdown PSU on shutdown of pi option HOT 2
- Print stutters while Homeassistant is unavailable HOT 3
- Disable automatic PSU power on
- Cant power on/off with PSUControl plugin HOT 1
- PSUControl shuts down PSU on Raspberry Pi just few seconds after startup HOT 2
- Setup Wizard Keeps Reappearing HOT 1
- Issie with OctoPrint-TPLinkSmartplug using Mk4 and TPLink PLug HOT 3
- feature request: temporally disable "auto off"
- need help with setting up gpio in octoprint docker HOT 1
- Idle poweroff is not working on prusa MK4 with Firmware 5.1.2 (heatbreak X temp and target temp causes problems) HOT 7
- Octoprint 1.10.2 new install trapped on PSU Control Setup Wizard Page. previous greyed out and finish just clicks but doesn't do anything HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octoprint-psucontrol.