Comments (5)
Hm, with
include karax / prelude
import karax/vstyles
proc createDom(): VNode =
result = buildHtml(tdiv(style = style((StyleAttr.cssFloat, kstring"right")))):
text "Hello World!"
setRenderer createDom
I get
<div id="ROOT" style="float: right;">Hello World!</div>
on the current master branch of Karax.
However, if you are using it just to generate HTML, then this might be a bug as https://www.w3schools.com/jsref/prop_style_cssfloat.asp says cssFloat is only used for the JS property to set it, despite the actual name being float
. So when using the Karax DSL directly on the non JS backend, I get
<div style="css-float: right; ">Hello World!</div>
which seems to match your issue. Not sure what the best fix here is. An easy one is just a hack to check and see which backend is being used, and translate accordingly. My guess is that this is the only CSS property with this issue, I glanced through the other ones that Karax provides and those seemed fine.
Suggested workaround:
proc createDom(): VNode =
result = buildHtml(tdiv(style = "float: right;".toCSS)):
text "Hello World!"
It is possible to directly set the style using Karax.
from karax.
Yes, I'm using Karax to generate HTML in this case.
from karax.
@Araq is there any situation where StyleAttr
is preferable to toCss
(introduced in #158) ? toCss
is easier to use IMO because it's easier to go back and forth between css vs karax (and doesn't have this issue);
if there's no such situation, should we migrate the code in karax to use toCss
and promote it in docs?
from karax.
Can't remember, but what I do remember: The style handling code is most performance critical and can easily dominate the performance profile in a real-world app, not just in benchmarks. You probaly need to make toCss
a compiletime operation.
from karax.
You probaly need to make toCss a compiletime operation.
then maybe it's time to merge nim-lang/Nim#15528 (const now works with ref types) ? There are so many use cases for it (including table at CT, jsonNode at CT etc);
(so that proc toCss*(a: static string): VStyle
overload can be defined)
(note that addressable const should not use const
but let a {.rom.} = [1,2,3]
, so it doesn't clash with nim-lang/RFCs#257 in any way; see timotheecour/Nim#553 for some pre-RFC)
from karax.
Related Issues (20)
- Delay in redrawing dom HOT 6
- buildHtml does not capture closure variables HOT 2
- Broken functionalities when karax used with grammarly or languagetool (and possibly other extensions) HOT 8
- How to run a function on onclick event in a button? HOT 4
- Boolean Attributes in DSL HOT 6
- Event example does not work HOT 8
- Release 1.2.3 HOT 5
- view doesn't update when changing state in setInterval HOT 3
- IndexDefect on array HOT 3
- Karax input text becoming null HOT 1
- Async karax? HOT 3
- Empty content editable raises an error HOT 1
- How to attach and detach a custom a `Node` to the karax dom? HOT 1
- Karax does not update event handlers HOT 4
- stack size exceeded error on js target HOT 1
- `verbitam` content is appended every time it changes HOT 1
- runtime error on redraw in `removeAllEventHandlers` proc HOT 2
- SVG rendering HOT 2
- 1.3.2 has a tag and release, but karax.nimble version still 1.3.1 HOT 1
- inline closures in loop all capture the last instance for onclick HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karax.