GithubHelp home page GithubHelp logo

Comments (7)

LyaCJ avatar LyaCJ commented on July 17, 2024 1

I got that, Thank you very much!!

from fl-bench.

KarhouTam avatar KarhouTam commented on July 17, 2024 1

I'm the maintainer, so that's what I need to do. 🤗

from fl-bench.

KarhouTam avatar KarhouTam commented on July 17, 2024

Hello, LyaCJ.
Regarding your 1st question, this is because when the split is user, the whole set of clients is split into [train client, test client]. This means that there is no testset in train client and no trainset in testclient. For the bug you encountered, I will fix the code ASAP.

For your 2nd question, the trainset and testset need to be in the same distribution, but with no intersection. In my code, FL methods won't train models with test data while training.

For your confusion about accuracy, e.g., 13.65% -> 79.73%, 13.65% is the average accuracy of evaluation over sampled clients' testsets before local training, while 79.73% is the accuracy after local fine-tuning.

Note that each client's testset only contains data sampled from the same data distribution as the trainset.

e.g.

If client A's train data are from classes [1,2,3,4], the test data client A holds are also only from [1,2,3,4].

Testsets in each client are small, and because of your Non-IID data partitioning setup, each client model can fit very well into their data distribution. As a result, client models perform well on their private testset after local fine-tuning (especially if the test set is small) is reasonable.

from fl-bench.

KarhouTam avatar KarhouTam commented on July 17, 2024

Glad to solve your issue.
If you still wanna run code over user split, make sure to keep your eye on my work and pull the latest code after I fix the bug. 😏
Thanks for your attention.

from fl-bench.

LyaCJ avatar LyaCJ commented on July 17, 2024

ok!!!

from fl-bench.

KarhouTam avatar KarhouTam commented on July 17, 2024

Hi, @LyaCJ.
I have already fixed the bug, you can pull the latest now!

from fl-bench.

LyaCJ avatar LyaCJ commented on July 17, 2024

Wow, so nice of you!!! Thank you very much!

from fl-bench.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.