GithubHelp home page GithubHelp logo

Comments (4)

 avatar commented on June 3, 2024 1

Very cool project btw!

from fsql.

 avatar commented on June 3, 2024

Mind if I take this one? I see you have a branch with some refactorings. Not sure if you've tackled it there, but I've identified that it could be a problem with the logic in:
main::containsAny(exclusions []string, path string)

It may be simpler to use the os.FileInfo that we have access to, to do directory Vs file comparison edge cases.

Let me know if there are any other considerations that you've thought about!

from fsql.

kashav avatar kashav commented on June 3, 2024

@jonesbrianc26 Go for it!

Ended up moving the logic for this to query.Execute. I suggest working off the new branch, but feel free to work off master if you prefer (it'll be the same fix either way).

So from what I can tell, the problem comes from my naive method of checking if the file path string contains the excluded directory, i.e. .gitignore contains .git, so it's ignored for -.git, whereas it doesn't contain .git/, so it isn't ignored for -.git/.

I haven't really given this much thought yet, but there might be a method to solve this with regular expressions.

I look forward to seeing what you come up with!

from fsql.

kashav avatar kashav commented on June 3, 2024

Resolved in #21! 😄

from fsql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.