Comments (4)
Very cool project btw!
from fsql.
Mind if I take this one? I see you have a branch with some refactorings. Not sure if you've tackled it there, but I've identified that it could be a problem with the logic in:
main::containsAny(exclusions []string, path string)
It may be simpler to use the os.FileInfo that we have access to, to do directory Vs file comparison edge cases.
Let me know if there are any other considerations that you've thought about!
from fsql.
@jonesbrianc26 Go for it!
Ended up moving the logic for this to query.Execute
. I suggest working off the new branch, but feel free to work off master if you prefer (it'll be the same fix either way).
So from what I can tell, the problem comes from my naive method of checking if the file path string contains the excluded directory, i.e. .gitignore
contains .git
, so it's ignored for -.git
, whereas it doesn't contain .git/
, so it isn't ignored for -.git/
.
I haven't really given this much thought yet, but there might be a method to solve this with regular expressions.
I look forward to seeing what you come up with!
from fsql.
Resolved in #21!
from fsql.
Related Issues (20)
- How to show human readable file sizes? HOT 3
- Attribute modifiers HOT 5
- Cannot start commands with `fsql`; have to use $GOPATH/bin/fsql HOT 4
- Add -v Version output HOT 1
- regression test? HOT 3
- Exclude duplicate entries HOT 3
- Allow search in directories starting with - HOT 5
- Go vendoring? HOT 5
- `fsql "SELECT * from . WHERE size > 1gb"` doesn't work HOT 4
- Add support for UPDATE / DELETE operations HOT 2
- Path as attribute HOT 1
- Respecting attribute order HOT 1
- Add support for querying file contents HOT 4
- SELECT query does not print folders from recursive paths. HOT 4
- feature request: plugin API for extending the fsql abilities HOT 3
- Windows support? HOT 2
- Feature request: limit number of results
- Compatibility with future Go versions HOT 1
- Failing darwin builds require a bump of x/sys HOT 2
- missing path as token HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsql.