I need a modulo operator for this class. Can someone help? Thanks about bigint

[SethPoulsen]

I've never contributed to a project on GitHub before, so I'm not sure how to do the "pull request" thing, but adding this to the .cpp (with a corresponding declaration in the .h) does the trick to give the modulo if you want to do Bigint % int:

//Modulo
int Bigint::operator%(int divisor)
{
    long int remains = 0;
    for (int i = 0; i < number.size(); i++){
        remains = (remains + number[number.size() - i - 1]) % divisor;
        if(i != number.size() - 1)
        {
            remains = remains*base;
            remains %= divisor;
        }
    }
    if(positive)
        return remains;
    else
        return -remains + divisor;
}

I'm going to get to work now on figuring out how to implement Bigint % Bigint

Sorry my formatting is bad, I'd appreciate any tips on how to use the site better and how to properly request that this be put into the code.

[kasparsklavins]

If you feel like it then sure, go ahead. I'd appreciate it.

[SethPoulsen]

I'm realizing, if I'm going to do Bigint % Bigint, then I might as well do Bigint / Bigint , because you basically have to do the division to get the remainder. I would think we would want both functions to use essentially the same code.

Should we have an option to return just the quotient, just the remainder, and an option to return both the quotient and the remainder?

[kasparsklavins]

Sounds good. But make it a private method. I want to keep the public api simple.

[SethPoulsen]

Ok, that sounds good. I'll need to use the multiplication and subtraction to do it (well, it will make it a lot easier). Are those stable right now?

[kasparsklavins]

Multiplication seems produce incorrect results in some cases, I'll go over it later today (or tomorrow, depending on the timezone)