GithubHelp home page GithubHelp logo

Comments (4)

jodh-intel avatar jodh-intel commented on May 22, 2024

/cc @sboeuf, @bergwolf.

from kata-containers.

sboeuf avatar sboeuf commented on May 22, 2024

@jodh-intel Thanks for taking the time to explain this very accurately. I think that we should do two things to avoid those kind of issues as much as possible.

  • Add to the developer documentation the good practices to update a .proto file
  • Write a binary checking for bad practices, that would be run by the CI as part of the make check

from kata-containers.

bergwolf avatar bergwolf commented on May 22, 2024

Agreed @sboeuf. And I think we should only declare a stable API when releasing kata containers and try not to commit to any inter-operability during early stage of development for the sake of easier maintenance. IOW, while it is a nice thing to have, I would prefer to enforce it only when we are about to release kata containers.

from kata-containers.

jodh-intel avatar jodh-intel commented on May 22, 2024

Yes, at this stage, I think we still expect changes to the .proto files but once we are providing packaged components, we need to be extra careful.

I've raised kata-containers/agent#175 which should give us another level of protection.

from kata-containers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.