Comments (7)
/cc @mcastelino.
from runtime.
We needed only a few things from this package and that's why we copy/pasted what was needed instead of importing the whole thing. If we think we might need those other functionalities from the upstream package, then yes I agree we might reconsider it, and import it directly.
from runtime.
@jodh-intel @egernst @sboeuf I would keep the upstream package as we need other ethtool functionality for new use cases that we plan to add to Kata like RDMA support.
from runtime.
@mcastelino we're not relying on the upstream package, so you mean we would move to the upstream one, right ?
from runtime.
I'd vote for that if at all possible since, stepping back, we're using a copy of an upstream package. We don't even have dep
to tell us if upstream changed (think security fixes).
from runtime.
Agree, I moved from the vendoring the ethtool package to using a copy of the code to keep the code-base smaller. If we are going to need this for other functionality as well, and as @jodh-intel mentioned we need to consider security fixes, I would vendor in the upstream package.
If no one objects, I'll vendor the upstream.
from runtime.
@amshinde I think everybody agreed, you can go ahead and vendor the upstream package !
from runtime.
Related Issues (20)
- Attaching multiple network interfaces to Firecracker container HOT 5
- add observability bind mount to retrieve logs from guest HOT 1
- don't pass cpuset details to guest when creating container
- 9pfs: Tar reports that file shrank HOT 2
- clh: Upgrade to cloud-hypervisor v0.14.0
- Kata Containers 1.x container hangs running Python scripts HOT 12
- Enabling sangbox_cgroup_only causes the creation of pods with small memory.limits settings to fail HOT 3
- Disk io limit of kata container (bps and iops) HOT 2
- Thread creation can be orders of magnitude slower in Kata containers under certain conditions HOT 20
- versions: Upgrade to cloud-hypervisor release v0.14.1
- cli: the incorrect info of command "kata-runtime exec" HOT 1
- `Dead agent` will block kata-agent exit HOT 6
- cli: the default hostname should not be "runc" HOT 1
- kill: does kata container support "terminationGracePeriodSeconds" in pod definition of kubernetes? HOT 5
- versions: Upgrade to cloud-hypervisor v15.0
- Kata on MSFT Win10 WSL2 HOT 5
- Manually hot-plugged interfaces don't work HOT 2
- Network hotplug issues with firecracker HOT 7
- Revert 1.13.0-alpha1 version bump, as the release was never tagged.
- Incorrect agent version specified in versions.yaml HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from runtime.