Comments (7)
I will. But very busy now. 😢
from aws-ecr-action.
Ah, that is wonderful. Thank you so much for sharing, @jondavidjohn !
from aws-ecr-action.
@Torvaney ended up throwing together a PR to better support this ^
from aws-ecr-action.
@jondavidjohn - I got a notification from you commenting on this thread, although it doesn't seem to be here anymore(?)
In answer to your question, I haven't yet succeeded with using extra_build_args
- have you found a solution?
from aws-ecr-action.
I have, and happy to share. I tried just using the extra_build_args
on it's own, and it never seemed to work.
I found out that --cache-from
expects this image to already be pulled and available locally for it to work. This is why when I tested it locally it worked because I already had the image built locally!
Adding another step just before this action to pull the image made it work as expected. You do have to authenticate with ecr/docker first and then pull the image you want to reference with your cache.
Also, make sure you're tagging a latest
in your build step so you can reference that for the cache.
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Pull Cache Image
run: |
aws ecr get-login-password | docker login --username AWS --password-stdin ${{ secrets.AWS_ACCOUNT_ID }}.
.dkr.ecr.us-east-2.amazonaws.com
docker pull ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.us-east-2.amazonaws.com/rails:latest
env:
AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
AWS_ACCESS_KEY_ID: ${{ secrets.DEPLOY_USER_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.DEPLOY_USER_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: 'us-east-2'
- uses: docker://ghcr.io/kciter/aws-ecr-action:034328f198022c55596bf0dfef5befbdba5043b6
with:
access_key_id: ${{ secrets.DEPLOY_USER_AWS_ACCESS_KEY_ID }}
secret_access_key: ${{ secrets.DEPLOY_USER_SECRET_ACCESS_KEY }}
account_id: ${{ secrets.AWS_ACCOUNT_ID }}
repo: rails
region: us-east-2
tags: latest,${{ github.sha }}
extra_build_args: --cache-from ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.us-east-2.amazonaws.com/rails:latest
from aws-ecr-action.
All this to say, it's a workaround, even if a bit ugly. Would love to see this cache functionality integrated in the action. I assume PRs would be welcome for this @kciter?
from aws-ecr-action.
Sorry, I'm too late merge.
from aws-ecr-action.
Related Issues (20)
- Check if image already exists on ECR HOT 2
- Support for Docker buildx
- Invalid security token HOT 1
- Bad Yaml results in silent failure
- Docker Hub HOT 1
- ERROR: ca-certificates-20191127-r2: BAD archive HOT 1
- Module build failed HOT 13
- Fails when path is not . HOT 1
- Action failing with multiple tags
- Feature to add lifecycle policy HOT 1
- Problem with using path argument HOT 5
- Using path: HOT 1
- Space in comma separated tags results in incorrect tagging
- New release v4 HOT 2
- unable to prepare context: path "***.dkr.ecr.eu-central-1.amazonaws.com.." issue HOT 4
- Doesn't work with public repositories
- Missing KMS encryption
- [PROBLEM] extra_build_args doesnt work HOT 3
- set-output is deprecated
- Release Version for GitHub Actions Upgrade? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-ecr-action.