GithubHelp home page GithubHelp logo

Comments (4)

Keats avatar Keats commented on June 1, 2024
  1. Do like Chrono does: https://docs.rs/chrono/latest/src/chrono/offset/utc.rs.html#84-108 and have a different function if it's in WASM just importing the js sys lib in wasm

2 is not great because that means you now need to set the timestamp everytime you use the library while I'm expecting a lot of Validation struct to be mostly static

from jsonwebtoken.

BrandonDyer64 avatar BrandonDyer64 commented on June 1, 2024

@Keats There is an open PR that adds specific wasm support (#318), but it needs to be merged

from jsonwebtoken.

Keats avatar Keats commented on June 1, 2024

Yes. As mentioned in the PR, it's missing CI

from jsonwebtoken.

BrandonDyer64 avatar BrandonDyer64 commented on June 1, 2024

@Keats The structure of Validation does not generally imply being static as the sub field is user specific. The original PR I submitted allowed for a user to choose to add a custom exp timestamp if they want.

I made another PR that uses js_sys when on wasm32-unknown-unknown, but I heavily urge you to please find a way to let the user specify a timestamp for validation

from jsonwebtoken.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.