GithubHelp home page GithubHelp logo

Comments (7)

Keats avatar Keats commented on June 12, 2024 1

I think we want to add crit at least since it's part of JWS. zip is simple and can be deserialize to an enum {Deflate, Other(String)} if we wanted and enc should be an enum as well

from jsonwebtoken.

Keats avatar Keats commented on June 12, 2024

Definitely out of scope

from jsonwebtoken.

inferiorhumanorgans avatar inferiorhumanorgans commented on June 12, 2024

The problem I've run into is that the Header struct doesn't allow access to arbitrary headers (e.g. JWS §4.2, JWE § 4.1) and only allows access to a subset of the defined headers. In this case I'm after the zip header (JWS § 4.1.3) which would allow inflating compressed JWE objects as a external trait.

from jsonwebtoken.

Keats avatar Keats commented on June 12, 2024

We could dump all other fields not part of the spec in a hashmap? I'd take a PR for that if that's not a breaking change.

from jsonwebtoken.

inferiorhumanorgans avatar inferiorhumanorgans commented on June 12, 2024

Sure, however I think there are only two registered headers not covered by the struct: crit (JWS § 4.1.11) and zip (JWE § 4.1.3) so it would come down to whether it's worth potential allocation or if it's worth carrying around a couple extra fields for the most common cases.

from jsonwebtoken.

inferiorhumanorgans avatar inferiorhumanorgans commented on June 12, 2024

Sounds great.

from jsonwebtoken.

Keats avatar Keats commented on June 12, 2024

It would have to come from a PR though, and that's a breaking change

from jsonwebtoken.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.