Add notification support for Hipchat about keel

[rusenask]

Hi,

Sounds awesome! Yeah, I guess notifications would be a nice first step as a new package here https://github.com/keel-hq/keel/tree/master/extension/notification.

Regarding approvals (bot stuff) it might be more tricky. If we get notifications in I could try refactoring bot package to be more "app agnostic" since in theory it shouldn't matter where the message is coming from (slack, hipchat, rocketchat). This would save a lot of time in the future as more chat integrations are being added.

If you have any questions or need help with anything, please let me know :)

[glower]

Hi, thx for the comment, the PR is out, hope it is all ok (my first PR for a open source project). Add a new notification provider was very easy. It could be cool to have similar system for the approvals bots. If you have time for refactoring its cool, otherwise I have time to do it as well, if it is ok for you.

[rusenask]

Hi, notifications PR looks good, however I don't use hipchat to test it out :) the problem with approvals and bot is that it uses two interfaces (slack real time messaging) and another slack webhooks based client.

I will move slack specific functions to a subpackage as the first step. Then, we will see how much is duplicated as I understand message structure might be different (bot name included or not).

[glower]

Cool, thx for the fast code review. I testet it with HipChat. I just did small refactoring by myself, If you wait for 5 min I will make a PR for it and you can have a look (just decline if you dont like it). I just moved all the bot code to some sub module. I don't think I can share any code from the slack.

[rusenask]

Sounds good, looking forward to see that PR :) Edit: I thought it would make sense to have a generic interface to handle bot commands, where every bot implementation would have to implement it. If we move everything to a separate packages it might become difficult to track what subset of all commands the bot package is implementing. On the other hand, we could start with separate packages and then try to come up with a generic solution (I took similar approach with k8s and helm providers and tracked images). What are your thoughts on this?

…

On Fri, Dec 15, 2017, 4:34 PM Igor Komlew ***@***.***> wrote: Cool, thx for the fast code review. I testet it with HipChat. I just did small refactoring by myself, If you wait for 5 min I will make a PR for it and you can have a look (just decline if you dont like it). I just moved all the bot code to some sub module. I don't think I can share any code from the slack. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIqNKYTognFbiMCEUKN0Fzfc-_aS-3oDks5tAp-pgaJpZM4RBKQG> .

[glower]

I think it is a good idea. So now, as second approval bot is implemented I can see some patterns. We can try to define a meaningful interface for a bot. I would like to work on it. For now I think you can close this issue

[rusenask]

thanks @glower !