GithubHelp home page GithubHelp logo

Comments (14)

rusenask avatar rusenask commented on July 24, 2024 2

created new release with 0.4.1, cloud.docker.com is building it now (although it's quite slow) so image should be available soon. Configurable timeout could be in values.yml with other config:

keel:
  # keel policy (all/major/minor/patch/force)
  policy: all
  # update timeout in seconds (defaults to 300)
  timeout: 9001
  # images to track and update
  images:
    - repository: image.repository # [1]
      tag: image.tag  # [2]

Would that make sense?

from keel.

fujin avatar fujin commented on July 24, 2024 2

confirming fixed in 0.4.1:
image

from keel.

rusenask avatar rusenask commented on July 24, 2024 1

okay, 0.4.1 is available, just noticed that my own Keel upgraded itself and sent notification to slack faster than I got an email from dockerhub. Hope that helps!

from keel.

rusenask avatar rusenask commented on July 24, 2024

Hi! there is 30 seconds timeout for release upgrades, I guess it's a bit optimistic if you have larger images?

from keel.

fujin avatar fujin commented on July 24, 2024

@rusenask yea, that could well be it. this image is 625MB (has a lot of runtime tooling) and there are a number of replicas in the deployment (a HPA controls it, so it varies, but anywhere from 2~36)

gcr.io/dd-engineering/identity 1.8.1 69916c4eff80 7 hours ago 625MB

the ability to control the timeout via configuration would be welcome as a workaround for now!

from keel.

fujin avatar fujin commented on July 24, 2024

Is that timeout @ https://github.com/rusenask/keel/blob/28553b3e9db8076de8c5b0d50eb664c4b6f7e92f/provider/helm/helm.go#L329 ?

from keel.

rusenask avatar rusenask commented on July 24, 2024

Yeah that's the one. Are you modifying timeout when updating releases with CLI? I see default 300 seconds in helm. I can quickly bump it and add configuration later.

from keel.

fujin avatar fujin commented on July 24, 2024

@rusenask we have not had to modify the timeout when updating releases with CLI, no.

that sounds awesome to me. 🥇 the Helm stuff looks great so far.

from keel.

theckman avatar theckman commented on July 24, 2024

@rusenask (I work with @fujin) -- that would definitely work for us!

from keel.

fujin avatar fujin commented on July 24, 2024

@rusenask yup, looks good to me. 👍

from keel.

rusenask avatar rusenask commented on July 24, 2024

I guess it would be nice to see how long release update took, from time it looks like ~1 minute :)

P.S. Bonus feature - if you invite Keel to your channel (or you can message it directly) you can:
screen shot 2017-07-26 at 09 07 41

from keel.

theckman avatar theckman commented on July 24, 2024

@rusenask for the latest test deployment, webhooks were 47 seconds apart.

from keel.

theckman avatar theckman commented on July 24, 2024

I guess I should mention that this is our smallest environment with only two Pods in the deployment. Other environments may have 6+.

from keel.

rusenask avatar rusenask commented on July 24, 2024

That timeout is for single helm deployment, each deployment will have a refreshed timeout. Since Helm provider is slightly different from k8s - it would make sense to start helm upgrades in parallel (as it's waiting for ok/not ok) .

from keel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.